From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] Cygwin: select: don't report read ready on a FIFO never, opened for writing
Date: Tue, 18 Oct 2022 17:45:52 +0200 [thread overview]
Message-ID: <Y07KMM0XyO6ua9/Q@calimero.vinschen.de> (raw)
In-Reply-To: <7163de6a-758b-5268-8ed1-eaa34fea7d94@cornell.edu>
On Sep 23 11:31, Ken Brown wrote:
> Patch attached. I'm also attaching a test case, that behaves the same on
> Cygwin as on Linux.
Interesting case, but thinking about the scenario, it seems logical to
do it this way.
> @@ -1043,6 +1043,8 @@ writer_shmem:
> set_pipe_non_blocking (get_handle (), flags & O_NONBLOCK);
> nwriters_lock ();
> inc_nwriters ();
> + if (!writer_opened () )
> + set_writer_opened ();
My personal preference would be to skip the writer_opened() check
and just call set_writer_opened(), but that's just me. If you like
it better that way, just push.
Thanks,
Corinna
next prev parent reply other threads:[~2022-10-18 15:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 15:31 Ken Brown
2022-10-18 15:45 ` Corinna Vinschen [this message]
2022-10-19 12:31 ` Ken Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y07KMM0XyO6ua9/Q@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).