From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH v2 1/2] Allow deriving the current user's home directory via the HOME variable
Date: Tue, 18 Oct 2022 19:02:50 +0200 [thread overview]
Message-ID: <Y07cOhhwu4ExRDzb@calimero.vinschen.de> (raw)
In-Reply-To: <1r1pq0r7-o3s3-so08-o426-296542797q94@tzk.qr>
Hi Johannes,
On Sep 21 13:58, Johannes Schindelin wrote:
> Hi Corinna,
>
> sorry for the blast from the past, but I am renewing my efforts to
> upstream Git for Windows' patches that can be upstreamed.
>
> On Thu, 17 Dec 2015, Corinna Vinschen wrote:
Well, not even 7 years, so what? :)
> > On Dec 17 19:05, Johannes Schindelin wrote:
> > > + DWORD max = sizeof wbuf / sizeof *wbuf;
> > > + DWORD len = GetEnvironmentVariableW (key, wbuf, max);
> >
> > This call to GetEnvironmentVariableW looks gratuitous to me. Why don't
> > you simply call getenv? It did the entire job already, it avoids the
> > requirement for a local buffer, and in case of $HOME it even did the
> > Win32->POSIX path conversion. If there's a really good reason for using
> > GetEnvironmentVariableW it begs at least for a longish comment.
>
> My only worry is that `getenv("HOME")` might receive a "Cygwin-ified"
> version of the value. That is, `getenv("HOME")` might return something
> like `/cygdrive/c/Users/corinna` when we expect it to return
> `C:\Users\corinna` instead.
Haha, yeah, that's exactly what it does. Look at environ.cc, search for
conv_envvars. There's a list of env vars which are converted
automatically. So getenv ("HOME") already does what you need, you just
have to adapt the code accordingly, i. e.
if ((home = getenv ("HOME")))
return strdup (home);
if (((home_drive = getenv ("HOMEDRIVE")
[...]
return (char *) cygwin_create_path (CCP_WIN_A_TO_POSIX, home);
However, on second thought, I wonder if the HOMEDRIVE/HOMEPATH/USERPROFILE
code is really required. AFAICS, it's just a duplication of the effort
already done in fetch_windows_home(), isn't it?
HOMEDRIVE/HOMEPATH are generated from the DB data returned in
USER_INFO_3 or via ldap anyway, and fetch_windows_home() also falls back
to fetching the user profile path, albeit from the registry.
That means, the results from the "env" method is equivalent to the
"windows" method, just after checking $HOME. That's a bit of a downer.
Assuming the "env" method would *only* check for $HOME, the user would
have the same result by simply setting nsswitch.conf accordingly:
home: env windows
Corinna
next prev parent reply other threads:[~2022-10-18 17:02 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 13:06 [PATCH] Allow overriding the " Johannes Schindelin
2015-10-21 18:32 ` Corinna Vinschen
2015-10-22 15:38 ` Johannes Schindelin
2015-10-23 9:10 ` Corinna Vinschen
2015-10-23 9:41 ` Corinna Vinschen
2015-10-23 12:00 ` Johannes Schindelin
2015-12-17 18:05 ` [PATCH v2 0/2] Support deriving the current user's home directory via HOME Johannes Schindelin
2015-12-17 18:05 ` [PATCH v2 1/2] Allow deriving the current user's home directory via the HOME variable Johannes Schindelin
2015-12-17 20:20 ` Corinna Vinschen
2022-09-21 11:58 ` Johannes Schindelin
2022-10-18 17:02 ` Corinna Vinschen [this message]
2022-10-23 21:04 ` Johannes Schindelin
2022-10-24 11:37 ` Corinna Vinschen
2022-11-10 15:16 ` Johannes Schindelin
2022-11-10 15:22 ` Corinna Vinschen
2022-11-18 8:18 ` Johannes Schindelin
2022-11-21 11:41 ` Corinna Vinschen
2023-03-28 8:21 ` Johannes Schindelin
2015-12-17 18:05 ` [PATCH v2 2/2] Respect `db_home` setting even for the SYSTEM account Johannes Schindelin
2015-12-17 20:49 ` Corinna Vinschen
2015-12-17 21:02 ` Corinna Vinschen
2022-09-21 12:00 ` Johannes Schindelin
2022-09-21 11:51 ` [PATCH v3 0/3] Support deriving the current user's home directory via HOME Johannes Schindelin
2022-09-21 11:51 ` [PATCH v3 1/3] Allow deriving the current user's home directory via the HOME variable Johannes Schindelin
2022-09-21 11:52 ` [PATCH v3 2/3] Respect `db_home` setting even for SYSTEM/Microsoft accounts Johannes Schindelin
2022-09-21 11:52 ` [PATCH v3 3/3] Respect `db_home: env` even when no uid can be determined Johannes Schindelin
2023-03-28 8:17 ` [PATCH v4 0/3] Support deriving the current user's home directory via HOME Johannes Schindelin
2023-03-28 8:17 ` [PATCH v4 1/3] Allow deriving the current user's home directory via the HOME variable Johannes Schindelin
2023-03-28 10:35 ` Corinna Vinschen
2023-03-28 12:34 ` Jon Turney
2023-03-28 13:31 ` Corinna Vinschen
2023-03-29 8:36 ` Corinna Vinschen
2023-04-03 6:39 ` Johannes Schindelin
2023-03-28 8:17 ` [PATCH v4 2/3] Respect `db_home` setting even for SYSTEM/Microsoft accounts Johannes Schindelin
2023-03-28 10:16 ` Corinna Vinschen
2023-04-03 6:36 ` Johannes Schindelin
2023-04-03 10:59 ` Corinna Vinschen
2023-04-03 13:32 ` Johannes Schindelin
2023-03-28 8:17 ` [PATCH v4 3/3] Respect `db_home: env` even when no uid can be determined Johannes Schindelin
2023-03-28 10:17 ` Corinna Vinschen
2023-04-03 6:45 ` Johannes Schindelin
2023-04-03 13:12 ` Johannes Schindelin
2023-04-03 13:29 ` Corinna Vinschen
2023-04-03 13:57 ` Johannes Schindelin
2023-04-03 19:23 ` Corinna Vinschen
2023-04-04 15:11 ` Johannes Schindelin
2023-04-03 13:19 ` Johannes Schindelin
2023-04-03 14:44 ` [PATCH v5 0/3] Support deriving the current user's home directory via HOME Johannes Schindelin
2023-04-03 14:44 ` [PATCH v5 1/3] Allow deriving the current user's home directory via the HOME variable Johannes Schindelin
2023-04-03 18:36 ` Corinna Vinschen
2023-04-04 15:12 ` Johannes Schindelin
2023-04-03 14:45 ` [PATCH v5 2/3] Respect `db_home` setting even for SYSTEM/Microsoft accounts Johannes Schindelin
2023-04-03 18:37 ` Corinna Vinschen
2023-04-04 15:12 ` Johannes Schindelin
2023-04-03 14:45 ` [PATCH v5 3/3] Respect `db_home: env` even when no uid can be determined Johannes Schindelin
2023-04-04 15:07 ` [PATCH v6 0/4] Support deriving the current user's home directory via HOME Johannes Schindelin
2023-04-04 15:07 ` [PATCH v6 1/4] Allow deriving the current user's home directory via the HOME variable Johannes Schindelin
2023-04-04 15:07 ` [PATCH v6 2/4] Respect `db_home` setting even for SYSTEM/Microsoft accounts Johannes Schindelin
2023-04-04 15:07 ` [PATCH v6 3/4] uinfo: special-case IIS APPPOOL accounts Johannes Schindelin
2023-04-04 15:07 ` [PATCH v6 4/4] Do not rely on `getenv ("HOME")`'s path conversion Johannes Schindelin
2023-04-06 8:37 ` Corinna Vinschen
2023-04-06 9:54 ` Johannes Schindelin
2023-04-06 10:28 ` Corinna Vinschen
2023-05-22 11:12 ` [PATCH v7 0/4] Support deriving the current user's home directory via HOME Johannes Schindelin
2023-05-22 11:12 ` [PATCH v7 1/4] Allow deriving the current user's home directory via the HOME variable Johannes Schindelin
2023-05-22 11:12 ` [PATCH v7 2/4] Respect `db_home` setting even for SYSTEM/Microsoft accounts Johannes Schindelin
2023-05-22 11:12 ` [PATCH v7 3/4] uinfo: special-case IIS APPPOOL accounts Johannes Schindelin
2023-05-22 11:13 ` [PATCH v7 4/4] Do not rely on `getenv ("HOME")`'s path conversion Johannes Schindelin
2023-06-06 13:33 ` [PATCH v7 0/4] Support deriving the current user's home directory via HOME Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y07cOhhwu4ExRDzb@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).