From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com, Hamish McIntyre-Bhatty <cygwin@hamishmb.com>
Subject: Re: [PATCH] Fix typo in faq-programming.xml
Date: Wed, 26 Oct 2022 10:13:38 +0200 [thread overview]
Message-ID: <Y1jsMppSUV5oH++z@calimero.vinschen.de> (raw)
In-Reply-To: <6a50dd6a-e805-bbf0-200a-25a1892bfa5b@hamishmb.com>
Hi Hamish,
Thanks for the patch.
On Oct 25 19:50, Hamish McIntyre-Bhatty wrote:
> Hi there,
>
> This is my first time submitting a patch over email, so hopefully I'll get
> it right. Are there eventually plans for submitting merge requests directly
> with git in some way?
No, but by email is usually simple by using `git format-patch' and
`git send-email'.
> This is a simple one-line patch to fix a typo I noticed in the programming
> FAQ. Patch follows below. I follow the list via GMANE, but to make sure I
> see any replies, it's probably best to reply to cygwin at hamishmb dot com.
The only problem with your patch is that all this text will become
part of the commit message. What you should do is this:
- Hack your patch
- Commit it locally with a headline, an empty line, and a bit of
descriptive text as commit message. if it's an obvious patch,
the headline may be sufficient.
- git format-patch -1
This creates a file like 0001-foo.patch
- Now, if you want to add text to your mail which is *not* supposed
to become part of the commit message, open the 0001-foo.patch file
in your editor and add the editoral notes *after* the line consisting
of only three dashes.
- Last, but not least, send the patch to the mailing list. Assuming
you did set user.email in your git config:
git send-email --to='cygwin-patches@...' 0001-foo.patch
Do you want to try that or shall I push this with just the headline as
commit?
Thanks,
Corinna
>
> Hamish
>
> diff --git a/winsup/doc/faq-programming.xml b/winsup/doc/faq-programming.xml
> index c2c4004c1..7945b6b88 100644
> --- a/winsup/doc/faq-programming.xml
> +++ b/winsup/doc/faq-programming.xml
> @@ -1051,7 +1051,7 @@ a Windows environment which Cygwin handles
> automatically.
> <question><para>How should I port my Unix GUI to Windows?</para></question>
> <answer>
>
> -<para>Like other Unix-like platforms, the Cygwin distribtion includes many
> of
> +<para>Like other Unix-like platforms, the Cygwin distribution includes many
> of
> the common GUI toolkits, including X11, X Athena widgets, Motif, Tk, GTK+,
> and Qt. Many programs which rely on these toolkits will work with little,
> if
> any, porting work if they are otherwise portable. However, there are a few
next prev parent reply other threads:[~2022-10-26 8:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 18:50 Hamish McIntyre-Bhatty
2022-10-26 8:13 ` Corinna Vinschen [this message]
2022-10-26 10:35 ` Hamish McIntyre-Bhatty
2022-10-26 10:36 ` Hamish McIntyre-Bhatty
2022-10-26 13:26 Hamish McIntyre-Bhatty
2022-10-27 11:32 ` Corinna Vinschen
2022-10-27 13:21 ` Hamish McIntyre-Bhatty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1jsMppSUV5oH++z@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-patches@cygwin.com \
--cc=cygwin@hamishmb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).