From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH v2 1/2] Allow deriving the current user's home directory via the HOME variable
Date: Thu, 10 Nov 2022 16:22:19 +0100 [thread overview]
Message-ID: <Y20XK4VybCriMmn/@calimero.vinschen.de> (raw)
In-Reply-To: <66o0nq89-4599-np26-625n-2n8oon6p558q@tzk.qr>
On Nov 10 16:16, Johannes Schindelin wrote:
> Hi Corinna,
>
> On Mon, 24 Oct 2022, Corinna Vinschen wrote:
>
> > On Oct 23 23:04, Johannes Schindelin wrote:
> > > On Tue, 18 Oct 2022, Corinna Vinschen wrote:
> > > [...]
> > > > That means, the results from the "env" method is equivalent to the
> > > > "windows" method, just after checking $HOME. That's a bit of a downer.
> > > >
> > > > Assuming the "env" method would *only* check for $HOME, the user would
> > > > have the same result by simply setting nsswitch.conf accordingly:
> > > >
> > > > home: env windows
> > >
> > > Except when the domain controller is (temporarily) unreachable, e.g. when
> > > sitting in a train with poor or no internet connection. Then that latter
> > > approach would have the "benefit" of having to wait 10-15 seconds before
> > > the network call says "nope".
> > >
> > > This particular issue has hit enough Git for Windows users that I found
> > > myself being forced to implement these patches and run with them for the
> > > past seven years.
> > >
> > > Given the scenario of an unreachable domain controller, I hope you agree
> > > that the `env` support added in the proposed patches _has_ merit.
> >
> > Yes, I don't doubt an `env' method checking for $HOME even a bit.
>
> Cool!
>
> > I'm just not sure as far as HOMEDRIVE/HOMEPATH/USERPROFILE are
> > concerned. Those vars should be left alone, but we can't control that,
> > so reading them from genuine sources is preferred.
>
> I do not recall the exact reasons because it has been a good while since I
> worked on these patches. But I do remember that we had to have a fall-back
> for the many scenarios in Git for Windows where `HOME` is not even set,
> and we specifically had to add HOMEDRIVE/HOMEPATH handling because
> USERPROFILE alone would lead to problems (IIRC there were plenty of
> corporate setups where USERPROFILE pointed to a potentially-disconnected
> network drive).
>
> > Sure, the downside in terms of the LDAP server is clear to me
> >
> > So I guess it's ok to allow the env method to read the values of those
> > vars from the env. I would just feel better if we urge the
> > user to set $HOME and read that exclusively.
>
> I would feel better about that, too, if it was practical.
>
> But I cannot ask millions of Git for Windows users to please go ahead and
> first configure their `HOME` variable correctly, it took much less time to
> implement the patch we're discussing than asking all users individually
> ;-)
>
> And since there is nothing specific about Git for Windows here, I expect
> Cygwin users to benefit from this feature, too.
>
> With this context in mind, I would like to ask to integrate the patch
> as-is, including the HOMEDRIVE/HOMEPATH and USERPROFILE fall-backs.
Can't do that, sorry. Two replies before I sent a necessary change,
which needs inclusion first.
Thanks,
Corinna
next prev parent reply other threads:[~2022-11-10 15:22 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 13:06 [PATCH] Allow overriding the " Johannes Schindelin
2015-10-21 18:32 ` Corinna Vinschen
2015-10-22 15:38 ` Johannes Schindelin
2015-10-23 9:10 ` Corinna Vinschen
2015-10-23 9:41 ` Corinna Vinschen
2015-10-23 12:00 ` Johannes Schindelin
2015-12-17 18:05 ` [PATCH v2 0/2] Support deriving the current user's home directory via HOME Johannes Schindelin
2015-12-17 18:05 ` [PATCH v2 1/2] Allow deriving the current user's home directory via the HOME variable Johannes Schindelin
2015-12-17 20:20 ` Corinna Vinschen
2022-09-21 11:58 ` Johannes Schindelin
2022-10-18 17:02 ` Corinna Vinschen
2022-10-23 21:04 ` Johannes Schindelin
2022-10-24 11:37 ` Corinna Vinschen
2022-11-10 15:16 ` Johannes Schindelin
2022-11-10 15:22 ` Corinna Vinschen [this message]
2022-11-18 8:18 ` Johannes Schindelin
2022-11-21 11:41 ` Corinna Vinschen
2023-03-28 8:21 ` Johannes Schindelin
2015-12-17 18:05 ` [PATCH v2 2/2] Respect `db_home` setting even for the SYSTEM account Johannes Schindelin
2015-12-17 20:49 ` Corinna Vinschen
2015-12-17 21:02 ` Corinna Vinschen
2022-09-21 12:00 ` Johannes Schindelin
2022-09-21 11:51 ` [PATCH v3 0/3] Support deriving the current user's home directory via HOME Johannes Schindelin
2022-09-21 11:51 ` [PATCH v3 1/3] Allow deriving the current user's home directory via the HOME variable Johannes Schindelin
2022-09-21 11:52 ` [PATCH v3 2/3] Respect `db_home` setting even for SYSTEM/Microsoft accounts Johannes Schindelin
2022-09-21 11:52 ` [PATCH v3 3/3] Respect `db_home: env` even when no uid can be determined Johannes Schindelin
2023-03-28 8:17 ` [PATCH v4 0/3] Support deriving the current user's home directory via HOME Johannes Schindelin
2023-03-28 8:17 ` [PATCH v4 1/3] Allow deriving the current user's home directory via the HOME variable Johannes Schindelin
2023-03-28 10:35 ` Corinna Vinschen
2023-03-28 12:34 ` Jon Turney
2023-03-28 13:31 ` Corinna Vinschen
2023-03-29 8:36 ` Corinna Vinschen
2023-04-03 6:39 ` Johannes Schindelin
2023-03-28 8:17 ` [PATCH v4 2/3] Respect `db_home` setting even for SYSTEM/Microsoft accounts Johannes Schindelin
2023-03-28 10:16 ` Corinna Vinschen
2023-04-03 6:36 ` Johannes Schindelin
2023-04-03 10:59 ` Corinna Vinschen
2023-04-03 13:32 ` Johannes Schindelin
2023-03-28 8:17 ` [PATCH v4 3/3] Respect `db_home: env` even when no uid can be determined Johannes Schindelin
2023-03-28 10:17 ` Corinna Vinschen
2023-04-03 6:45 ` Johannes Schindelin
2023-04-03 13:12 ` Johannes Schindelin
2023-04-03 13:29 ` Corinna Vinschen
2023-04-03 13:57 ` Johannes Schindelin
2023-04-03 19:23 ` Corinna Vinschen
2023-04-04 15:11 ` Johannes Schindelin
2023-04-03 13:19 ` Johannes Schindelin
2023-04-03 14:44 ` [PATCH v5 0/3] Support deriving the current user's home directory via HOME Johannes Schindelin
2023-04-03 14:44 ` [PATCH v5 1/3] Allow deriving the current user's home directory via the HOME variable Johannes Schindelin
2023-04-03 18:36 ` Corinna Vinschen
2023-04-04 15:12 ` Johannes Schindelin
2023-04-03 14:45 ` [PATCH v5 2/3] Respect `db_home` setting even for SYSTEM/Microsoft accounts Johannes Schindelin
2023-04-03 18:37 ` Corinna Vinschen
2023-04-04 15:12 ` Johannes Schindelin
2023-04-03 14:45 ` [PATCH v5 3/3] Respect `db_home: env` even when no uid can be determined Johannes Schindelin
2023-04-04 15:07 ` [PATCH v6 0/4] Support deriving the current user's home directory via HOME Johannes Schindelin
2023-04-04 15:07 ` [PATCH v6 1/4] Allow deriving the current user's home directory via the HOME variable Johannes Schindelin
2023-04-04 15:07 ` [PATCH v6 2/4] Respect `db_home` setting even for SYSTEM/Microsoft accounts Johannes Schindelin
2023-04-04 15:07 ` [PATCH v6 3/4] uinfo: special-case IIS APPPOOL accounts Johannes Schindelin
2023-04-04 15:07 ` [PATCH v6 4/4] Do not rely on `getenv ("HOME")`'s path conversion Johannes Schindelin
2023-04-06 8:37 ` Corinna Vinschen
2023-04-06 9:54 ` Johannes Schindelin
2023-04-06 10:28 ` Corinna Vinschen
2023-05-22 11:12 ` [PATCH v7 0/4] Support deriving the current user's home directory via HOME Johannes Schindelin
2023-05-22 11:12 ` [PATCH v7 1/4] Allow deriving the current user's home directory via the HOME variable Johannes Schindelin
2023-05-22 11:12 ` [PATCH v7 2/4] Respect `db_home` setting even for SYSTEM/Microsoft accounts Johannes Schindelin
2023-05-22 11:12 ` [PATCH v7 3/4] uinfo: special-case IIS APPPOOL accounts Johannes Schindelin
2023-05-22 11:13 ` [PATCH v7 4/4] Do not rely on `getenv ("HOME")`'s path conversion Johannes Schindelin
2023-06-06 13:33 ` [PATCH v7 0/4] Support deriving the current user's home directory via HOME Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y20XK4VybCriMmn/@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).