From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] Cygwin: Improve FAQ on early breakpoint for ASLR
Date: Tue, 15 Nov 2022 11:46:49 +0100 [thread overview]
Message-ID: <Y3NuGWbczdW5f+rC@calimero.vinschen.de> (raw)
In-Reply-To: <a2e01953-f6ef-cf08-f6e1-0c7632391ede@dronecode.org.uk>
Hi Jon,
the patch is fine, but...
On Nov 12 14:30, Jon Turney wrote:
> On 04/11/2022 15:29, Pedro Alves wrote:
> > On 2022-11-04 12:53 p.m., Jon Turney wrote:
> > > +<para>
> > > + (It may be necessary to use the <command>gdb</command> command <command>set
> > > + disable-randomization on</command> to turn off ASLR for the debugee to
> > > + prevent the base address getting randomized.)
> > > +</para>
> > > </answer></qandaentry>
> >
> > Typo: debugee -> debuggee
>
> Thanks for catching that.
>
> Patch attached.
>
> > Note that "on" is the default.
>
> True. But the API used by gdb to turn off ASLR isn't supported by some
> versions of Windows.
>
> This sentence could be a lot more explicit about all the details here, but
> I'm just trying to be brief.
> From be24c9b69e72648690a477fd2f15b0a9c6374713 Mon Sep 17 00:00:00 2001
> From: Jon Turney <jon.turney@dronecode.org.uk>
> Date: Sat, 12 Nov 2022 14:16:36 +0000
> Subject: [PATCH] Cygwin: Fix typo in FAQ
>
> The consonant in 'debug' is doubled in 'debuggee' just as it is in
> 'debugger'.
>
> Fixes: 8c68a8a4
It would be great if we could get used to using the same syntax as the
Linux kernel project to document stuff. I'm trying to follow their lead
for a while. For fixes to former commits, it looks like this in the
kernel, at the end of the commit message:
Fixes: 123456789012 ("title of commit 123456789012")
Yeah, core.abbrev is 12 digits. I'm using this setting for quite some
time locally.
Anyway, please push.
Thanks,
Corinna
next prev parent reply other threads:[~2022-11-15 10:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 17:04 Jon Turney
2022-11-03 18:22 ` Jeremy Drake
2022-11-04 10:34 ` Corinna Vinschen
2022-11-04 12:53 ` Jon Turney
2022-11-04 13:16 ` Corinna Vinschen
2022-11-04 15:29 ` Pedro Alves
2022-11-12 14:30 ` Jon Turney
2022-11-15 10:46 ` Corinna Vinschen [this message]
2022-11-28 13:00 ` Jon Turney
2022-11-28 14:41 ` Corinna Vinschen
2022-12-05 15:23 ` Johannes Schindelin
2022-12-11 13:54 ` Jon Turney
2022-12-11 14:45 ` Johannes Schindelin
2022-12-14 17:37 ` Jon Turney
2023-03-28 8:26 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3NuGWbczdW5f+rC@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).