public inbox for cygwin-patches@cygwin.com
 help / color / mirror / Atom feed
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH v2] Cygwin: fsync: Fix EINVAL for block device.
Date: Sun, 22 Jan 2023 10:01:13 +0100	[thread overview]
Message-ID: <Y8z7Wcwlr5IZOIej@calimero.vinschen.de> (raw)
In-Reply-To: <20230122000846.54372-1-takashi.yano@nifty.ne.jp>

On Jan 22 09:08, Takashi Yano wrote:
> The commit af8a7c13b516 has a problem that fsync returns EINVAL for
> block device. This patch treats block devices as a special case.
> https://cygwin.com/pipermail/cygwin/2023-January/252916.html
> 
> Fixes: af8a7c13b516 ("Cygwin: fsync: Return EINVAL for special files.")
> Reported-by: Yano Ray <yanorei@hotmail.co.jp>
> Reviewed-by: Corinna Vinschen <corinna@vinschen.de>
> Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
> ---
>  winsup/cygwin/fhandler/base.cc | 3 ++-
>  winsup/cygwin/release/3.4.6    | 5 +++++
>  2 files changed, 7 insertions(+), 1 deletion(-)
>  create mode 100644 winsup/cygwin/release/3.4.6

Thanks, please push.


Corinna

      reply	other threads:[~2023-01-22  9:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-22  0:08 Takashi Yano
2023-01-22  9:01 ` Corinna Vinschen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y8z7Wcwlr5IZOIej@calimero.vinschen.de \
    --to=corinna-cygwin@cygwin.com \
    --cc=cygwin-patches@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).