public inbox for cygwin-patches@cygwin.com
 help / color / mirror / Atom feed
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH 0/3] Fix fstat on FIFOs, part 2
Date: Fri, 19 Feb 2021 18:07:32 +0100	[thread overview]
Message-ID: <YC/wVCqFCu9OmH9S@calimero.vinschen.de> (raw)
In-Reply-To: <20210218171348.3847-1-kbrown@cornell.edu>

On Feb 18 12:13, Ken Brown via Cygwin-patches wrote:
> The first patch fixes a bug, in which fstat on FIFOs sometimes used
> pipe handles instead of file handles.
> 
> The second and third patches should improve the efficiency of fstat
> and open on FIFOs.
> 
> Ken Brown (3):
>   Cygwin: define fhandler_fifo::fstat
>   Cygwin: fstat_helper: always use handle in call to get_file_attribute
>   Cygwin: FIFO: temporarily keep a conv_handle in syscalls.cc:open
> 
>  winsup/cygwin/fhandler.h            |  1 +
>  winsup/cygwin/fhandler_disk_file.cc |  3 +--
>  winsup/cygwin/fhandler_fifo.cc      | 23 +++++++++++++++++++++++
>  winsup/cygwin/syscalls.cc           | 22 +++++++++++++++++++---
>  4 files changed, 44 insertions(+), 5 deletions(-)
> 
> -- 
> 2.30.0

LGTM, please push.


Thanks,
Corinna

      parent reply	other threads:[~2021-02-19 17:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-18 17:13 Ken Brown
2021-02-18 17:13 ` [PATCH 1/3] Cygwin: define fhandler_fifo::fstat Ken Brown
2021-02-18 17:13 ` [PATCH 2/3] Cygwin: fstat_helper: always use handle in call to get_file_attribute Ken Brown
2021-02-18 17:13 ` [PATCH 3/3] Cygwin: FIFO: temporarily keep a conv_handle in syscalls.cc:open Ken Brown
2021-02-19 17:07 ` Corinna Vinschen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YC/wVCqFCu9OmH9S@calimero.vinschen.de \
    --to=corinna-cygwin@cygwin.com \
    --cc=cygwin-patches@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).