Re: [PATCH] cpuinfo: fix check; add AVX features; move SME, SEV/_ES features

[Corinna Vinschen <corinna-cygwin@cygwin.com>]

Hi Brian,

On Feb 16 09:00, Brian Inglis wrote:
> 
> fix cpuid 0x80000007 supported check;
> Linux 5.11 💕 Valentine's Day Edition 💕 added features and changes:
> add Intel 0x00000007 EDX:23 avx512_fp16 and 0x00000007:1 EAX:4 avx_vnni;
> group scattered AMD 0x8000001f EAX Secure Mem/Encrypted Virt features at end:
> 0 sme, 1 sev, 3 sev_es (more to come not yet displayed)
> ---
>  winsup/cygwin/fhandler_proc.cc | 46 ++++++++++++++++++----------------
>  1 file changed, 24 insertions(+), 22 deletions(-)
> 

> diff --git a/winsup/cygwin/fhandler_proc.cc b/winsup/cygwin/fhandler_proc.cc
> index 8e23c0609485..501c157daae5 100644
> --- a/winsup/cygwin/fhandler_proc.cc
> +++ b/winsup/cygwin/fhandler_proc.cc
> @@ -1293,7 +1293,7 @@ format_proc_cpuinfo (void *, char *&destbuf)
>  
>  /* features scattered in various CPUID levels. */
>        /* cpuid 0x80000007 edx */
> -      if (maxf >= 0x00000007)
> +      if (maxe >= 0x80000007)

Maybe I'm a stickler here, but I think it would be nice to put this
bugfix into its own patch, prior to the patch adding the 5.11 features.


Thanks,
Corinna