public inbox for cygwin-patches@cygwin.com
 help / color / mirror / Atom feed
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] Cygwin: console: Prevent NULL pointer access in close().
Date: Mon, 22 Feb 2021 14:58:28 +0100	[thread overview]
Message-ID: <YDO4hCq+91d7KfmB@calimero.vinschen.de> (raw)
In-Reply-To: <20210222133017.432-1-takashi.yano@nifty.ne.jp>

On Feb 22 22:30, Takashi Yano via Cygwin-patches wrote:
> - There seems to be a case that shared_console_info is not set yet
>   when close() is called. This patch adds guard for such case.
> ---
>  winsup/cygwin/fhandler_console.cc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/winsup/cygwin/fhandler_console.cc b/winsup/cygwin/fhandler_console.cc
> index 6ded9eabf..96a8729e8 100644
> --- a/winsup/cygwin/fhandler_console.cc
> +++ b/winsup/cygwin/fhandler_console.cc
> @@ -1393,7 +1393,7 @@ fhandler_console::close ()
>  
>    release_output_mutex ();
>  
> -  if (con.owner == myself->pid)
> +  if (shared_console_info && con.owner == myself->pid)
>      {
>        char name[MAX_PATH];
>        shared_name (name, CONS_THREAD_SYNC, get_minor ());
> -- 
> 2.30.0

Pushed.


Thanks,
Corinna

      reply	other threads:[~2021-02-22 13:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-22 13:30 Takashi Yano
2021-02-22 13:58 ` Corinna Vinschen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YDO4hCq+91d7KfmB@calimero.vinschen.de \
    --to=corinna-cygwin@cygwin.com \
    --cc=cygwin-patches@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).