public inbox for
 help / color / mirror / Atom feed
From: Corinna Vinschen <>
Subject: Re: [PATCH] Cygwin: pty: Rename input named pipes.
Date: Mon, 22 Mar 2021 12:49:20 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi Takashi,

On Mar 21 12:59, Takashi Yano via Cygwin-patches wrote:
> - Currently, the name of input pipe is "ptyNNNN-from-master" for
>   cygwin process, and "ptyNNNN-to-slave" for non-cygwin process.
>   These are not only inconsistent with output pipes but also very
>   confusing.
>   With this patch, these are renamed to "ptyNNNN-from-master-cyg"
>   and "ptyNNNN-from-master" respectively.
> ---
>  winsup/cygwin/ | 2 +-
>  winsup/cygwin/          | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)

Actually... wouldn't it make more sense to call the Cygwin pipe

  pty%d-from-master / pty%d-to-slave

and the non-Cygwin one something like

  pty%d-from-master-nat / pty%d-to-slave-nat


After all, Cygwin is the norm, and non-Cygwin is the exception.

On second thought, this would also make sense for thr fhandler methods,
i. e.

  get_output_handle / get_output_handle_cyg


  get_output_handle_nat / get_output_handle

Probably the fhandler stuff is too much renaming for this release,
but we should do this for the next one, I think.


  reply	other threads:[~2021-03-22 11:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-21  3:59 Takashi Yano
2021-03-22 11:49 ` Corinna Vinschen [this message]
2021-03-23  0:38   ` Takashi Yano
2021-03-23  9:32     ` Corinna Vinschen
2021-03-23 11:49       ` Takashi Yano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).