From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] Cygwin: cfsetspeed: allow speed to be a numerical baud rate
Date: Mon, 12 Jul 2021 20:49:09 +0200 [thread overview]
Message-ID: <YOyOpWGCz2g47WG6@calimero.vinschen.de> (raw)
In-Reply-To: <d2c4a9cf-6ab0-26ca-596f-bdd7c0eec227@cornell.edu>
On Jul 12 08:57, Ken Brown wrote:
> The attached patch addresses
>
> https://cygwin.com/pipermail/cygwin/2021-July/248887.html
>
> I don't really understand the GPL issue, but I hope it's OK.
>
> Ken
> >From 0321ecd99050ad702a528797af48ea4d01531508 Mon Sep 17 00:00:00 2001
> From: Ken Brown <kbrown@cornell.edu>
> Date: Sun, 11 Jul 2021 07:04:58 -0400
> Subject: [PATCH] Cygwin: cfsetspeed: allow speed to be a numerical baud rate
>
> The Linux man page for cfsetspeed(3) specifies that the speed argument
> must be one of the constants Bnnn (e.g., B9600) defined in termios.h.
> But Linux in fact allows the speed to be the numerical baud rate
> (e.g., 9600). For consistency with Linux, we now do the same.
>
> Addresses: https://cygwin.com/pipermail/cygwin/2021-July/248887.html
> ---
> winsup/cygwin/release/3.2.1 | 4 +++
> winsup/cygwin/termios.cc | 59 +++++++++++++++++++++++++++++++++++++
> winsup/doc/new-features.xml | 11 +++++--
> 3 files changed, 71 insertions(+), 3 deletions(-)
LGTM, please push.
Thanks,
Corinna
prev parent reply other threads:[~2021-07-12 18:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 12:57 Ken Brown
2021-07-12 18:49 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOyOpWGCz2g47WG6@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).