Re: [PATCH] Cygwin: More profiler format + small issue fixes

[Corinna Vinschen <corinna-cygwin@cygwin.com>]

On Aug  1 23:52, Mark Geisert wrote:
> Make sure to cast to ulong all DWORD values displayed with format "%lu".
> More instances are fixed here than in either my earlier unused patch or
> Corinna's patch. I decided to use typedef..ulong for more compact code.
> 
> Address jturney's reported small issues:
> - Remove explicit external ref for cygwin_internal() as it is already
>   provided by <sys/cygwin.h>.
> - Leave intact ref for cygwin_dll_path[] as it is required by function(s)
>   in path.cc that profiler uses. Added comment to that effect.
> - Delete existing main() wrapper. Rename main2() to main(). This because
>   profiler is now a Cygwin program and doesn't need to dynamically load
>   cygwin1.dll.
> - Documentation issues will be addressed in a separate xml patch.
> 
> (I would have linked message-ids of Corinna's and Jon's messages for
> proper theading but I no longer have their original emails and the mail
> archives don't show msgids any more.)
> 
> ---
>  winsup/utils/profiler.cc | 60 ++++++++++++++--------------------------
>  1 file changed, 20 insertions(+), 40 deletions(-)

Pushed.


Thanks,
Corinna