From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] Cygwin: console: Fix a bug on input when signalled.
Date: Tue, 2 Nov 2021 15:48:17 +0100 [thread overview]
Message-ID: <YYFPsd2fzo8mjHIV@calimero.vinschen.de> (raw)
In-Reply-To: <20211102034010.1500-1-takashi.yano@nifty.ne.jp>
On Nov 2 12:40, Takashi Yano wrote:
> - This patch fixes the bug that Ctrl-C sometimes does not work as
> expected in Windows Terminal.
>
> Addresses:
> https://cygwin.com/pipermail/cygwin/2021-November/249749.html
> ---
> winsup/cygwin/fhandler_console.cc | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/winsup/cygwin/fhandler_console.cc b/winsup/cygwin/fhandler_console.cc
> index 940c66a6e..0501b36fa 100644
> --- a/winsup/cygwin/fhandler_console.cc
> +++ b/winsup/cygwin/fhandler_console.cc
> @@ -1178,6 +1178,10 @@ out:
> /* Discard processed recored. */
> DWORD dummy;
> DWORD discard_len = min (total_read, i + 1);
> + /* If input is signalled, do not discard input here because
> + tcflush() is already called from line_edit(). */
> + if (stat == input_signalled && !(ti->c_lflag & NOFLSH))
> + discard_len = 0;
> if (discard_len)
> ReadConsoleInputW (get_handle (), input_rec, discard_len, &dummy);
> return stat;
> --
> 2.33.0
This and the next patch pushed to master and cygwin-3_3-branch.
Thanks,
Corinna
prev parent reply other threads:[~2021-11-02 14:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 3:40 Takashi Yano
2021-11-02 14:48 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYFPsd2fzo8mjHIV@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).