From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] Cygwin: pipe: Avoid false EOF while reading output of C# programs.
Date: Mon, 8 Nov 2021 10:51:09 +0100 [thread overview]
Message-ID: <YYjzDcfEVMDKA7IA@calimero.vinschen.de> (raw)
In-Reply-To: <20211107034718.1048-1-takashi.yano@nifty.ne.jp>
On Nov 7 12:47, Takashi Yano wrote:
> - If output of C# program is redirected to pipe, pipe reader falsely
> detects EOF. This happens after overhaul of pipe implementation.
> This patch fixes the issue.
>
> Addresses:
> https://cygwin.com/pipermail/cygwin/2021-November/249777.html
> ---
> winsup/cygwin/fhandler_pipe.cc | 3 ++-
> winsup/cygwin/release/3.3.2 | 4 ++++
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/winsup/cygwin/fhandler_pipe.cc b/winsup/cygwin/fhandler_pipe.cc
> index 43771e8f7..bc06d157c 100644
> --- a/winsup/cygwin/fhandler_pipe.cc
> +++ b/winsup/cygwin/fhandler_pipe.cc
> @@ -393,7 +393,8 @@ fhandler_pipe::raw_read (void *ptr, size_t& len)
> }
> }
>
> - if (nbytes_now == 0 || status == STATUS_BUFFER_OVERFLOW)
> + if ((nbytes_now == 0 && !NT_SUCCESS (status))
> + || status == STATUS_BUFFER_OVERFLOW)
> break;
> }
> ReleaseMutex (read_mtx);
> diff --git a/winsup/cygwin/release/3.3.2 b/winsup/cygwin/release/3.3.2
> index 263c3efe6..2e48e39be 100644
> --- a/winsup/cygwin/release/3.3.2
> +++ b/winsup/cygwin/release/3.3.2
> @@ -8,3 +8,7 @@ Bug Fixes
> Addresses: https://sourceware.org/pipermail/newlib/2021/018626.html
>
> - Fix a permission problem when writing ACLs on Samba.
> +
> +- Fix the issue that pipe reader falsely detects EOF if the output of
> + the C# program is redirected to the pipe.
> + Addresses: https://cygwin.com/pipermail/cygwin/2021-November/249777.html
> --
> 2.33.0
Pushed.
Thanks,
Corinna
prev parent reply other threads:[~2021-11-08 9:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-07 3:47 Takashi Yano
2021-11-08 9:51 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYjzDcfEVMDKA7IA@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).