* [PATCH] Cygwin: pipe: Fix raw_write() for non-cygwin pipe with size zero.
@ 2021-11-11 8:19 Takashi Yano
2021-11-11 9:10 ` Corinna Vinschen
0 siblings, 1 reply; 2+ messages in thread
From: Takashi Yano @ 2021-11-11 8:19 UTC (permalink / raw)
To: cygwin-patches
- Currently, raw_write() fails to handle size zero pipe which may
be created by non-cygwin apps (e.g. Windows native ninja). This
patch fixes the issue.
Addresses:
https://cygwin.com/pipermail/cygwin/2021-November/249844.html
---
winsup/cygwin/fhandler_pipe.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/winsup/cygwin/fhandler_pipe.cc b/winsup/cygwin/fhandler_pipe.cc
index 13731437e..9392a28c1 100644
--- a/winsup/cygwin/fhandler_pipe.cc
+++ b/winsup/cygwin/fhandler_pipe.cc
@@ -449,7 +449,7 @@ fhandler_pipe_fifo::raw_write (const void *ptr, size_t len)
return -1;
}
- if (len <= pipe_buf_size)
+ if (len <= pipe_buf_size || pipe_buf_size == 0)
chunk = len;
else if (is_nonblocking ())
chunk = len = pipe_buf_size;
--
2.33.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Cygwin: pipe: Fix raw_write() for non-cygwin pipe with size zero.
2021-11-11 8:19 [PATCH] Cygwin: pipe: Fix raw_write() for non-cygwin pipe with size zero Takashi Yano
@ 2021-11-11 9:10 ` Corinna Vinschen
0 siblings, 0 replies; 2+ messages in thread
From: Corinna Vinschen @ 2021-11-11 9:10 UTC (permalink / raw)
To: cygwin-patches
On Nov 11 17:19, Takashi Yano wrote:
> - Currently, raw_write() fails to handle size zero pipe which may
> be created by non-cygwin apps (e.g. Windows native ninja). This
> patch fixes the issue.
>
> Addresses:
> https://cygwin.com/pipermail/cygwin/2021-November/249844.html
> ---
> winsup/cygwin/fhandler_pipe.cc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/winsup/cygwin/fhandler_pipe.cc b/winsup/cygwin/fhandler_pipe.cc
> index 13731437e..9392a28c1 100644
> --- a/winsup/cygwin/fhandler_pipe.cc
> +++ b/winsup/cygwin/fhandler_pipe.cc
> @@ -449,7 +449,7 @@ fhandler_pipe_fifo::raw_write (const void *ptr, size_t len)
> return -1;
> }
>
> - if (len <= pipe_buf_size)
> + if (len <= pipe_buf_size || pipe_buf_size == 0)
> chunk = len;
> else if (is_nonblocking ())
> chunk = len = pipe_buf_size;
> --
> 2.33.0
ACK. Please push.
Thanks,
Corinna
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-11 9:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-11 8:19 [PATCH] Cygwin: pipe: Fix raw_write() for non-cygwin pipe with size zero Takashi Yano
2021-11-11 9:10 ` Corinna Vinschen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).