From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] console: handle Unicode surrogate pairs
Date: Tue, 16 Nov 2021 15:00:06 +0100 [thread overview]
Message-ID: <YZO5Zp4KlZLKSP1R@calimero.vinschen.de> (raw)
In-Reply-To: <20211116221958.aa98712827563090a83a2565@nifty.ne.jp>
On Nov 16 22:19, Takashi Yano wrote:
> On Tue, 16 Nov 2021 11:26:10 +0100 (CET)
> Johannes Schindelin wrote:
> > When running Cygwin's Bash in the Windows Terminal (see
> > https://docs.microsoft.com/en-us/windows/terminal/ for details), Cygwin
> > is receiving keyboard input in the form of UTF-16 characters.
> > [...]
> > This fixes https://github.com/git-for-windows/git/issues/3281
Please put this into the release file.
> Thanks for the patch. LGTM.
> I will push the patch to the master branch.
>
>
> Corinna,
>
> Should we apply this patch also to cygwin-3_3-branch?
> Or should only the bug fix be for cygwin-3_3-branch?
The entire patch looks like a bugfix to me, but it depends on how
one looks at it. Your decision.
Thanks,
Corinna
prev parent reply other threads:[~2021-11-16 14:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 10:26 Johannes Schindelin
2021-11-16 13:19 ` Takashi Yano
2021-11-16 14:00 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZO5Zp4KlZLKSP1R@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).