From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [EXTERNAL] Re: [PATCH 2/5] Cygwin: resolver: Process options forward (not backwards)
Date: Tue, 18 Jan 2022 16:22:14 +0100 [thread overview]
Message-ID: <YebbJg3DZArOdlP2@calimero.vinschen.de> (raw)
In-Reply-To: <DM8PR09MB70957B6BFEAE91059D1371A6A5589@DM8PR09MB7095.namprd09.prod.outlook.com>
On Jan 18 13:58, Lavrentiev, Anton (NIH/NLM/NCBI) [C] via Cygwin-patches wrote:
> > I pushed patches 1 and 3 to 5. I fixed the consitency typo
> > throughout.
>
> Thanks! (and oops :-)
>
> > Right now, the debug flag gets set in several places throughout the
> > code. Given you set the debug flag above, doesn't that mean several
> > code snippets setting the debug flag later in the code can go away?
>
> No, they can't. The flag can be propagated from "res_init()" from the user
> land. When /etc/resolv.conf gets loaded, its "options" can also specify the
> debug setting (so it should become active since then), but formerly the code was
> using only the init-provided value in "get_resolv()" yet the debug setting from
> "options" (parsed by "get_options()") only affected the options themselves,
> but not the calling code in "get_resolv()", which kept on using the initial value.
> That made the remainder of the file parse to continue "silent" unless "res_init()"
> was previously called with RES_DEBUG.
>
> So that was, again, inconsistent! (see, I can spell it this time around :-)
>
> Post-"get_options()" assignment is not an additional assignment, it's a refresh
> of a possibly changed value (for a local "debug" variable). I think the patch is correct,
> and it works, for what I am concerned, -- I checked that and was using it.
Thanks for the description. Would you mind to recreate your patch with
a matching commit message text explaining the debug flag setting?
Thanks,
Corinna
next prev parent reply other threads:[~2022-01-18 15:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-17 18:03 Anton Lavrentiev
2022-01-17 18:03 ` [PATCH 1/5] Cygwin: resolver: Debug to output both IP and port # in native b.o Anton Lavrentiev
2022-01-17 18:03 ` [PATCH 2/5] Cygwin: resolver: Process options forward (not backwards) Anton Lavrentiev
2022-01-18 10:32 ` Corinna Vinschen
2022-01-18 13:58 ` [EXTERNAL] " Lavrentiev, Anton (NIH/NLM/NCBI) [C]
2022-01-18 15:22 ` Corinna Vinschen [this message]
2022-01-17 18:03 ` [PATCH 3/5] Cygwin: resolver: Format spec consitency for Windows errors Anton Lavrentiev
2022-01-17 18:03 ` [PATCH 4/5] Cygwin: resolver: A little more consitency in debug messages Anton Lavrentiev
2022-01-17 18:03 ` [PATCH 5/5] Cygwin: resolver: Added processing of AAAA records Anton Lavrentiev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YebbJg3DZArOdlP2@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).