public inbox for
 help / color / mirror / Atom feed
From: Corinna Vinschen <>
Subject: Re: [PATCH 0/2] Drop pointless loadlib.h use in utilities
Date: Mon, 28 Feb 2022 10:39:34 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Feb 26 16:40, Jon Turney wrote:
> The only remaining uses of loadlib.h are in cygcheck and strace, where it's
> used to load cygwin1.dll in both.
> Things could be further simplified, but it's probably worth keeping it
> around in it's present form since it's quite likely that
> LoadLibrary()/GetProcAddress() might be used again in future.
> Jon Turney (2):
>   Cygwin: Drop pointless loadlib.h includes in utilities
>   Cygwin: Drop use of loadlib.h in regtool
>  winsup/utils/     |  1 -
>  winsup/utils/ |  1 -
>  winsup/utils/        |  1 -
>  winsup/utils/          |  1 -
>  winsup/utils/     | 13 +------------
>  5 files changed, 1 insertion(+), 16 deletions(-)
> -- 
> 2.35.1

Good idea!

Shouldn't we actually remove loadlib.h as well?  What this code does is
to provide a safety measure to make sure the files are not stealthy
loaded from another dir.  This should not be necessary anymore, because
Windows itself provides matching functionality.

First of all, the system has an internal list of DLLs it always
loads from the system32 dir.  In Cygwin, see the content of
/proc/sys/KnownDlls/ and /proc/sys/KnownDlls32/

And for all other cases we can use LoadLibraryEx flags introduced a
couple of years ago, e. g.  LOAD_LIBRARY_SEARCH_SYSTEM32.  See


      parent reply	other threads:[~2022-02-28  9:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-26 16:40 Jon Turney
2022-02-26 16:40 ` [PATCH 1/2] Cygwin: Drop pointless loadlib.h includes " Jon Turney
2022-02-26 16:40 ` [PATCH 2/2] Cygwin: Drop use of loadlib.h in regtool Jon Turney
2022-02-28  9:44   ` Corinna Vinschen
2022-02-28  9:39 ` Corinna Vinschen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).