From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] Cygwin: path: Convert type of variable 'remlen' to DWORD.
Date: Mon, 14 Mar 2022 19:00:19 +0100 [thread overview]
Message-ID: <Yi+Csy507+6UVbxz@calimero.vinschen.de> (raw)
In-Reply-To: <20220314113658.6009-1-takashi.yano@nifty.ne.jp>
On Mar 14 20:36, Takashi Yano wrote:
> - Variable remlen stores the return value of QueryDosDeviceW(), so
> it is better to be DWORD.
> ---
> winsup/cygwin/path.cc | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/winsup/cygwin/path.cc b/winsup/cygwin/path.cc
> index eceafbbcf..e370843ee 100644
> --- a/winsup/cygwin/path.cc
> +++ b/winsup/cygwin/path.cc
> @@ -3523,8 +3523,7 @@ restart:
> {(WCHAR) towupper (upath.Buffer[4]), L':', L'\0'};
> WCHAR remote[MAX_PATH];
>
> -
> - int remlen = QueryDosDeviceW (drive, remote, MAX_PATH);
> + DWORD remlen = QueryDosDeviceW (drive, remote, MAX_PATH);
> if (remlen < 3)
> goto file_not_symlink; /* fallback */
> remlen -= 2; /* Two L'\0' */
> --
> 2.35.1
Thanks, please push.
Corinna
prev parent reply other threads:[~2022-03-14 18:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 11:36 Takashi Yano
2022-03-14 18:00 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yi+Csy507+6UVbxz@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).