* [PATCH] Cygwin: path: Convert type of variable 'remlen' to DWORD.
@ 2022-03-14 11:36 Takashi Yano
2022-03-14 18:00 ` Corinna Vinschen
0 siblings, 1 reply; 2+ messages in thread
From: Takashi Yano @ 2022-03-14 11:36 UTC (permalink / raw)
To: cygwin-patches
- Variable remlen stores the return value of QueryDosDeviceW(), so
it is better to be DWORD.
---
winsup/cygwin/path.cc | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/winsup/cygwin/path.cc b/winsup/cygwin/path.cc
index eceafbbcf..e370843ee 100644
--- a/winsup/cygwin/path.cc
+++ b/winsup/cygwin/path.cc
@@ -3523,8 +3523,7 @@ restart:
{(WCHAR) towupper (upath.Buffer[4]), L':', L'\0'};
WCHAR remote[MAX_PATH];
-
- int remlen = QueryDosDeviceW (drive, remote, MAX_PATH);
+ DWORD remlen = QueryDosDeviceW (drive, remote, MAX_PATH);
if (remlen < 3)
goto file_not_symlink; /* fallback */
remlen -= 2; /* Two L'\0' */
--
2.35.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] Cygwin: path: Convert type of variable 'remlen' to DWORD.
2022-03-14 11:36 [PATCH] Cygwin: path: Convert type of variable 'remlen' to DWORD Takashi Yano
@ 2022-03-14 18:00 ` Corinna Vinschen
0 siblings, 0 replies; 2+ messages in thread
From: Corinna Vinschen @ 2022-03-14 18:00 UTC (permalink / raw)
To: cygwin-patches
On Mar 14 20:36, Takashi Yano wrote:
> - Variable remlen stores the return value of QueryDosDeviceW(), so
> it is better to be DWORD.
> ---
> winsup/cygwin/path.cc | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/winsup/cygwin/path.cc b/winsup/cygwin/path.cc
> index eceafbbcf..e370843ee 100644
> --- a/winsup/cygwin/path.cc
> +++ b/winsup/cygwin/path.cc
> @@ -3523,8 +3523,7 @@ restart:
> {(WCHAR) towupper (upath.Buffer[4]), L':', L'\0'};
> WCHAR remote[MAX_PATH];
>
> -
> - int remlen = QueryDosDeviceW (drive, remote, MAX_PATH);
> + DWORD remlen = QueryDosDeviceW (drive, remote, MAX_PATH);
> if (remlen < 3)
> goto file_not_symlink; /* fallback */
> remlen -= 2; /* Two L'\0' */
> --
> 2.35.1
Thanks, please push.
Corinna
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-14 18:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-14 11:36 [PATCH] Cygwin: path: Convert type of variable 'remlen' to DWORD Takashi Yano
2022-03-14 18:00 ` Corinna Vinschen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).