From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] Cygwin: fsync: Return EINVAL for special files.
Date: Mon, 14 Mar 2022 10:50:26 +0100 [thread overview]
Message-ID: <Yi8P4sOhvgEuJ1oE@calimero.vinschen.de> (raw)
In-Reply-To: <20220311213707.1463-1-takashi.yano@nifty.ne.jp>
On Mar 12 06:37, Takashi Yano wrote:
> - Unlike linux, fsync() calls FlushFileBuffers() even for special
> files. This cause the problem reported in:
> https://cygwin.com/pipermail/cygwin/2022-March/251022.html
> This patch fixes the issue.
> ---
> winsup/cygwin/fhandler.cc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/winsup/cygwin/fhandler.cc b/winsup/cygwin/fhandler.cc
> index 98d7a3b2d..fc7bf0a0e 100644
> --- a/winsup/cygwin/fhandler.cc
> +++ b/winsup/cygwin/fhandler.cc
> @@ -1750,7 +1750,7 @@ fhandler_base::utimens (const struct timespec *tvp)
> int
> fhandler_base::fsync ()
> {
> - if (!get_handle () || nohandle ())
> + if (!get_handle () || nohandle () || pc.isspecial ())
> {
> set_errno (EINVAL);
> return -1;
> --
> 2.35.1
Ouch, yeah, that's obvious.
Thanks,
Corinna
prev parent reply other threads:[~2022-03-14 9:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-11 21:37 Takashi Yano
2022-03-14 9:50 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yi8P4sOhvgEuJ1oE@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).