* [PATCH] Cygwin: fsync: Return EINVAL for special files.
@ 2022-03-11 21:37 Takashi Yano
2022-03-14 9:50 ` Corinna Vinschen
0 siblings, 1 reply; 2+ messages in thread
From: Takashi Yano @ 2022-03-11 21:37 UTC (permalink / raw)
To: cygwin-patches
- Unlike linux, fsync() calls FlushFileBuffers() even for special
files. This cause the problem reported in:
https://cygwin.com/pipermail/cygwin/2022-March/251022.html
This patch fixes the issue.
---
winsup/cygwin/fhandler.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/winsup/cygwin/fhandler.cc b/winsup/cygwin/fhandler.cc
index 98d7a3b2d..fc7bf0a0e 100644
--- a/winsup/cygwin/fhandler.cc
+++ b/winsup/cygwin/fhandler.cc
@@ -1750,7 +1750,7 @@ fhandler_base::utimens (const struct timespec *tvp)
int
fhandler_base::fsync ()
{
- if (!get_handle () || nohandle ())
+ if (!get_handle () || nohandle () || pc.isspecial ())
{
set_errno (EINVAL);
return -1;
--
2.35.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Cygwin: fsync: Return EINVAL for special files.
2022-03-11 21:37 [PATCH] Cygwin: fsync: Return EINVAL for special files Takashi Yano
@ 2022-03-14 9:50 ` Corinna Vinschen
0 siblings, 0 replies; 2+ messages in thread
From: Corinna Vinschen @ 2022-03-14 9:50 UTC (permalink / raw)
To: cygwin-patches
On Mar 12 06:37, Takashi Yano wrote:
> - Unlike linux, fsync() calls FlushFileBuffers() even for special
> files. This cause the problem reported in:
> https://cygwin.com/pipermail/cygwin/2022-March/251022.html
> This patch fixes the issue.
> ---
> winsup/cygwin/fhandler.cc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/winsup/cygwin/fhandler.cc b/winsup/cygwin/fhandler.cc
> index 98d7a3b2d..fc7bf0a0e 100644
> --- a/winsup/cygwin/fhandler.cc
> +++ b/winsup/cygwin/fhandler.cc
> @@ -1750,7 +1750,7 @@ fhandler_base::utimens (const struct timespec *tvp)
> int
> fhandler_base::fsync ()
> {
> - if (!get_handle () || nohandle ())
> + if (!get_handle () || nohandle () || pc.isspecial ())
> {
> set_errno (EINVAL);
> return -1;
> --
> 2.35.1
Ouch, yeah, that's obvious.
Thanks,
Corinna
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-14 9:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-11 21:37 [PATCH] Cygwin: fsync: Return EINVAL for special files Takashi Yano
2022-03-14 9:50 ` Corinna Vinschen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).