public inbox for cygwin-patches@cygwin.com
 help / color / mirror / Atom feed
* [PATCH] Cygwin: Fix gmondump formatting goofs
@ 2022-03-15  0:47 Mark Geisert
  2022-03-16  7:43 ` Corinna Vinschen
  0 siblings, 1 reply; 3+ messages in thread
From: Mark Geisert @ 2022-03-15  0:47 UTC (permalink / raw)
  To: cygwin-patches

The rewrite of %X to %p was malhandled.  Fix that/them.

---
 winsup/utils/gmondump.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/winsup/utils/gmondump.c b/winsup/utils/gmondump.c
index ec9db0598..2d29e826d 100644
--- a/winsup/utils/gmondump.c
+++ b/winsup/utils/gmondump.c
@@ -162,7 +162,7 @@ gmondump1 (char *filename)
 
   note ("file %s, gmon version 0x%x, sample rate %d\n",
         filename, hdr.version, hdr.profrate);
-  note ("  address range 0x%p..0x%p\n", hdr.lpc, hdr.hpc);
+  note ("  address range %p..%p\n", hdr.lpc, hdr.hpc);
   note ("  numbuckets %d, hitbuckets %d, hitcount %d, numrawarcs %d\n",
         numbuckets, hitbuckets, hitcount, numrawarcs);
 
@@ -175,7 +175,7 @@ gmondump1 (char *filename)
       int   incr = (hdr.hpc - hdr.lpc) / numbuckets;
       for (res = 0; res < numbuckets; ++bucket, ++res, addr += incr)
         if (*bucket)
-          note ("    address 0x%p, hitcount %d\n", addr, *bucket);
+          note ("    address %p, hitcount %d\n", addr, *bucket);
       bucket -= numbuckets;
 
       if (numrawarcs)
@@ -186,7 +186,7 @@ gmondump1 (char *filename)
             error (0, "unable to read rawarc data");
           note ("  rawarc data follows...\n");
           for (res = 0; res < numrawarcs; ++rawarc, ++res)
-            note ("    from 0x%p, self 0x%p, count %d\n",
+            note ("    from %p, self %p, count %d\n",
                   rawarc->raw_frompc, rawarc->raw_selfpc, rawarc->raw_count);
         }
     }
-- 
2.35.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Cygwin: Fix gmondump formatting goofs
  2022-03-15  0:47 [PATCH] Cygwin: Fix gmondump formatting goofs Mark Geisert
@ 2022-03-16  7:43 ` Corinna Vinschen
  2022-03-17  3:06   ` Mark Geisert
  0 siblings, 1 reply; 3+ messages in thread
From: Corinna Vinschen @ 2022-03-16  7:43 UTC (permalink / raw)
  To: cygwin-patches

On Mar 14 17:47, Mark Geisert wrote:
> The rewrite of %X to %p was malhandled.  Fix that/them.

This should probably go into 3.3 as well.  Care to write a
matching entry for the release/3.3.5 file?


Thanks,
Corinna

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Cygwin: Fix gmondump formatting goofs
  2022-03-16  7:43 ` Corinna Vinschen
@ 2022-03-17  3:06   ` Mark Geisert
  0 siblings, 0 replies; 3+ messages in thread
From: Mark Geisert @ 2022-03-17  3:06 UTC (permalink / raw)
  To: cygwin-patches

Corinna Vinschen wrote:
> On Mar 14 17:47, Mark Geisert wrote:
>> The rewrite of %X to %p was malhandled.  Fix that/them.
> 
> This should probably go into 3.3 as well.  Care to write a
> matching entry for the release/3.3.5 file?
Done, under separate patch
https://cygwin.com/pipermail/cygwin-patches/2022q1/011851.html
Cheers,

..mark

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-03-17  3:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-15  0:47 [PATCH] Cygwin: Fix gmondump formatting goofs Mark Geisert
2022-03-16  7:43 ` Corinna Vinschen
2022-03-17  3:06   ` Mark Geisert

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).