From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: cygwin-patches@cygwin.com
Subject: Re: [PATCH] winsup: disable fortify source
Date: Wed, 16 Mar 2022 08:47:39 +0100 [thread overview]
Message-ID: <YjGWGzZmlpoP7AEo@calimero.vinschen.de> (raw)
In-Reply-To: <20220315032053.10985-1-vapier@gentoo.org>
On Mar 14 23:20, Mike Frysinger wrote:
> When using a compiler that automatically enables -D_FORTIFY_SOURCE,
> building winsup fails with errors like below. Since winsup is not
> setup to compile itself with _FORTIFY_SOURCE, disable it for now.
Yeah, the Windows headers are a problem. Who would have expected that...
> diff --git a/winsup/acinclude.m4 b/winsup/acinclude.m4
> index 7c900d70719a..ffd15aaaa86b 100644
> --- a/winsup/acinclude.m4
> +++ b/winsup/acinclude.m4
> @@ -16,7 +16,7 @@ if test -z "$newlib_headers"; then
> fi
> newlib_headers="$target_builddir/newlib/targ-include $newlib_headers"
>
> -AM_CPPFLAGS="-I${winsup_srcdir}/cygwin -I${target_builddir}/winsup/cygwin"
> +AM_CPPFLAGS="-U_FORTIFY_SOURCE -I${winsup_srcdir}/cygwin -I${target_builddir}/winsup/cygwin"
> AM_CPPFLAGS="${AM_CPPFLAGS} -isystem ${cygwin_headers}"
> for h in ${newlib_headers}; do
> AM_CPPFLAGS="${AM_CPPFLAGS} -isystem $h"
> --
> 2.34.1
Thanks, please push.
Corinna
prev parent reply other threads:[~2022-03-16 7:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 3:20 Mike Frysinger
2022-03-16 7:47 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjGWGzZmlpoP7AEo@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-patches@cygwin.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).