From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH v6] Cygwin: pipe: Avoid deadlock for non-cygwin writer.
Date: Fri, 1 Apr 2022 14:55:46 +0200 [thread overview]
Message-ID: <Ykb2UihKWV65bGEs@calimero.vinschen.de> (raw)
In-Reply-To: <20220401084505.2469-1-takashi.yano@nifty.ne.jp>
On Apr 1 17:45, Takashi Yano wrote:
> - As mentioned in commit message of the commit b531d6b0, if multiple
> writers including non-cygwin app exist, the non-cygwin app cannot
> detect pipe closure on the read side when the pipe is created by
> system account or the the pipe creator is running as service.
> This is because query_hdl which is held in write side also is a
> read end of the pipe, so the pipe is still alive for the non-cygwin
> app even after the reader is closed.
>
> To avoid this problem, this patch lets all processes in the same
> process group close query_hdl using newly introduced internal signal
> __SIGNONCYGCHLD when non-cygwin app is started.
>
> Addresses: https://cygwin.com/pipermail/cygwin/2022-March/251097.html
> ---
> winsup/cygwin/fhandler.h | 20 ++++++++++++++++++++
> winsup/cygwin/fhandler_pipe.cc | 23 +++++++++++++++++++++++
> winsup/cygwin/sigproc.cc | 10 ++++++++++
> winsup/cygwin/sigproc.h | 1 +
> winsup/cygwin/spawn.cc | 18 +++++++++++++++++-
> 5 files changed, 71 insertions(+), 1 deletion(-)
When you're happy with your patch, feel free to push.
Thanks,
Corinna
prev parent reply other threads:[~2022-04-01 12:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 8:45 Takashi Yano
2022-04-01 12:55 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ykb2UihKWV65bGEs@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).