public inbox for cygwin-patches@cygwin.com
 help / color / mirror / Atom feed
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] Cygwin: Have gmondump support ssp-generated gmon.out
Date: Fri, 10 Jun 2022 12:21:27 +0200	[thread overview]
Message-ID: <YqMbJwftMtPm+R6I@calimero.vinschen.de> (raw)
In-Reply-To: <20220609044731.30872-1-mark@maxrnd.com>

On Jun  8 21:47, Mark Geisert wrote:
> Cygwin tool ssp generates gmon.out files with different address
> resolution than other tools do. Two address bytes per bucket rather than
> the usual four address bytes. Gprof can deal with the difference but
> gmondump can't because the latter's gmon.out header validation fails.
> 
> - Remove the offending portion of the header validation code.
> - Make sure all code can handle differing address resolutions.
> - Display address resolution in verbose data dumps.
> - Change "rawarc" to "struct rawarc" in certain sizeof expressions to
>   avoid buffer overrun faults.
> - When "-v" (verbose) is specified, note when there is missing bucket
>   data or rawarc data.
> 
> ---
>  winsup/utils/gmondump.c | 35 ++++++++++++++++++++++-------------
>  1 file changed, 22 insertions(+), 13 deletions(-)

Pushed.


Thanks,
Corinna

      reply	other threads:[~2022-06-10 10:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-09  4:47 Mark Geisert
2022-06-10 10:21 ` Corinna Vinschen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YqMbJwftMtPm+R6I@calimero.vinschen.de \
    --to=corinna-cygwin@cygwin.com \
    --cc=cygwin-patches@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).