Re: [PATCH rebase] Add support for Compact OS compression for Cygwin

[Corinna Vinschen <corinna-cygwin@cygwin.com>]

On Jul 14 14:12, Christian Franke wrote:
> Corinna Vinschen wrote:
> > On Jul 14 12:02, Christian Franke wrote:
> > > [Sorry if this is the wrong list]
> > Yes, in theorie, but no worries.  However...
> 
> What is the correct list in theory ?-)

https://sourceware.org/cygwin-apps/ as the home of the "Cygwin-Apps"
is a good hint in itself ;)

> > Given compactos stuff is a OS thingy and not actually a Cygwin feature,
> > why do we need an ifdef CYGWIN?
> 
> Mainly because I didn't test on MSYS and other (which ever these are)
> environments. This also requires a recent release of MinGW-w64 headers
> (>=10.0.0) which includes (my) Compact OS patch.

I don't think there's any "other".

> > > +#endif
> > This ifdef still makes sense, of course ...
> 
> Could possibly also be enhanced to __MSYS__ and msys1.dll.

Not sure this makes sense.  Does their installer support CompactOS?
> 
> 
> > ... and on first glance, the
> > remainder of the patch LGTM.
> 
> Thanks. Attached is an alternative patch with most ifdefs removed.

LGTM.  I'm not going to push it, yet, because... do you still want to
add the aforementioned MSYS support?  If not, I'll just go ahead.


Thanks,
Corinna