public inbox for cygwin-patches@cygwin.com
 help / color / mirror / Atom feed
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH v2] Cygwin: dtable: Delete old kludge code for /dev/tty.
Date: Tue, 4 Jul 2023 16:36:26 +0200	[thread overview]
Message-ID: <ZKQualiRASkQFC8N@calimero.vinschen.de> (raw)
In-Reply-To: <20230704100338.255-1-takashi.yano@nifty.ne.jp>

On Jul  4 19:03, Takashi Yano wrote:
> This old kludge code assigns fhandler_console for /dev/tty even
> if the CTTY is not a console when stat() has been called. Due to
> this, the problem reported in
> https://cygwin.com/pipermail/cygwin/2023-June/253888.html
> occurs after the commit 3721a756b0d8 ("Cygwin: console: Make the
> console accessible from other terminals.").
> 
> This patch fixes the issue by dropping the old kludge code.
> 
> Though the exact reason why the kludge code was necessary is not
> clear enough, this kluge code has no longer seemed to be necessary
                                ^^^^^^^^^^^^^^^^^^^^
I'm not a native speaker myself, but

				no longer seems

might be better here.

Anyway, this is GTG.


Thanks,
Corinna

  reply	other threads:[~2023-07-04 14:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-04 10:03 Takashi Yano
2023-07-04 14:36 ` Corinna Vinschen [this message]
2023-07-07  3:30   ` Takashi Yano
2023-07-07  9:34     ` Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZKQualiRASkQFC8N@calimero.vinschen.de \
    --to=corinna-cygwin@cygwin.com \
    --cc=cygwin-patches@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).