From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH v2] Cygwin: Make gcc-specific code in <sys/cpuset.h> compiler-agnostic
Date: Mon, 10 Jul 2023 10:43:11 +0200 [thread overview]
Message-ID: <ZKvEn17628r8CDLa@calimero.vinschen.de> (raw)
In-Reply-To: <20230709075922.8599-1-mark@maxrnd.com>
On Jul 9 00:59, Mark Geisert wrote:
> The current version of <sys/cpuset.h> cannot be compiled by Clang due to
> the use of builtin versions of malloc, free, and memset. Their presence
> here was a dubious optimization anyway, so their usage has been
> converted to standard library functions.
>
> The use of __builtin_popcountl remains because Clang implements it just
> like gcc does. If/when some other compiler (Rust? Go?) runs into this
> issue we can deal with specialized handling then.
>
> The "#include <sys/cdefs>" here to define __inline can be removed since
> both of the new includes sub-include it.
>
> Addresses: https://cygwin.com/pipermail/cygwin/2023-July/253927.html
> Fixes: 9cc910dd33a5 (Cygwin: Make <sys/cpuset.h> safe for c89 compilations)
> Signed-off-by: Mark Geisert <mark@maxrnd.com>
>
> ---
> winsup/cygwin/include/sys/cpuset.h | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
Pushed.
Thanks,
Corinna
prev parent reply other threads:[~2023-07-10 8:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-09 7:59 Mark Geisert
2023-07-10 8:43 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKvEn17628r8CDLa@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).