From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] Cygwin: pthread: Take note of schedparam in pthread_create
Date: Thu, 13 Jul 2023 20:00:31 +0200 [thread overview]
Message-ID: <ZLA7vxwYFR0st7Xo@calimero.vinschen.de> (raw)
In-Reply-To: <20230713131414.3013-1-jon.turney@dronecode.org.uk>
On Jul 13 14:14, Jon Turney wrote:
> Take note of schedparam in any pthread_attr_t passed to pthread_create.
>
> postcreate() (racily, after the thread is actually created), sets the
> scheduling priority if it's inherited, but precreate() doesn't store any
> scheduling priority explicitly set via a non-default attr to create, so
> schedparam.sched_priority has the default value of 0.
>
> (I think this is another long-standing bug exposed by 4b51e4c1. Now we
> don't lie about the actual thread priority, it's apparent it's not
> really being set in this case.)
>
> Fixes testcase priority2.
Fixes: tag?
Signed-off-by: tag?
Looks good otherwise.
Thanks,
Corinna
next prev parent reply other threads:[~2023-07-13 18:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 13:14 Jon Turney
2023-07-13 18:00 ` Corinna Vinschen [this message]
2023-07-14 10:44 ` Jon Turney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLA7vxwYFR0st7Xo@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).