From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH v2] Cygwin: spawn: Fix segfalt when too many command line args are specified.
Date: Mon, 28 Aug 2023 13:18:16 +0200 [thread overview]
Message-ID: <ZOyCeBEP9MBjosHV@calimero.vinschen.de> (raw)
In-Reply-To: <ZOyAXmWkAH1BBCh2@calimero.vinschen.de>
On Aug 28 13:09, Corinna Vinschen wrote:
> On Aug 28 12:57, Corinna Vinschen wrote:
> > On Aug 28 18:46, Takashi Yano wrote:
> > > Previously, the number of command line args was not checked for
> > > cygwin process. Due to this, segmentation fault was caused if too
> > > many command line args are specified.
> > > https://cygwin.com/pipermail/cygwin/2023-August/254333.html
> > >
> > > Since char *argv[argc + 1] is placed on the stack in dll_crt0_1(),
> > > STATUS_STACK_OVERFLOW occurs if the stack does not have enough
> > > space.
> > >
> > > With this patch, the total length of the arguments and the size of
> > > argv[] is restricted to 1/4 of total stack size for the process, and
> > > spawnve() returns E2BIG if the size exceeds the limit.
> > > [...]
> > I tried this simple patch:
> >
> > diff --git a/winsup/cygwin/dcrt0.cc b/winsup/cygwin/dcrt0.cc
> > index 49b7a44aeb15..961dea4ab993 100644
> > --- a/winsup/cygwin/dcrt0.cc
> > +++ b/winsup/cygwin/dcrt0.cc
> > @@ -978,11 +978,8 @@ dll_crt0_1 (void *)
> > a change to an element of argv[] it does not affect Cygwin's argv.
> > Changing the the contents of what argv[n] points to will still
> > affect Cygwin. This is similar (but not exactly like) Linux. */
> > - char *newargv[__argc + 1];
> > - char **nav = newargv;
> > - char **oav = __argv;
> > - while ((*nav++ = *oav++) != NULL)
> > - continue;
> > + char **newargv = (char **) malloc ((__argc + 1) * sizeof (char **));
> > + memcpy (newargv, __argv, (__argc + 1) * sizeof (char **));
> > /* Handle any signals which may have arrived */
> > sig_dispatch_pending (false);
> > _my_tls.call_signal_handler ();
> >
> > and the testcase `LC_ALL=C sed 's/x/y/' $(seq 1000000)' simply ran
> > as desired. Combined with a bit of error checking...
>
> We may also get away with storing it in the Windows heap, but I didn't
> test this .
No, we don't. The Windows heap would not be inherited by a forked
child and argv would be lost. Sounds not great.
Corinna
next prev parent reply other threads:[~2023-08-28 11:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 9:46 Takashi Yano
2023-08-28 10:57 ` Corinna Vinschen
2023-08-28 11:09 ` Corinna Vinschen
2023-08-28 11:18 ` Corinna Vinschen [this message]
2023-08-28 12:14 ` Takashi Yano
2023-08-28 12:09 ` Takashi Yano
2023-08-28 12:20 ` Takashi Yano
2023-08-28 12:27 ` Takashi Yano
2023-08-28 13:23 ` Takashi Yano
2023-08-28 12:51 ` Takashi Yano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOyCeBEP9MBjosHV@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).