Re: [PATCH] Cygwin: cpuinfo: Linux 6.5: add AMD 0x8000001f EAX 14 debug_swap SEV-ES full debug state swap

[Corinna Vinschen <corinna-cygwin@cygwin.com>]

Hi Brian,

nothing against the patch as such, but your subject line is not so nice.
As it becomes the commit message first line, it should be shorter.  Add
more descriptive text instead, please, and make sure that it tells the
reader what you're really doing, i. e.:

You write "add <something>", but your patch is actually exchanging one
<somthing> with another <something>.

The reader of the commit message would probably like to know why you're
doing that. Partially copying the original Linux kernel commit message
should be ok.

Also, given that changes a string, does it qualify for a "Fixes:" tag?


Thanks,
Corinna


On Aug 30 22:10, Brian Inglis wrote:
> Signed-off-by: Brian Inglis <Brian.Inglis@Shaw.ca>
> ---
>  winsup/cygwin/fhandler/proc.cc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/winsup/cygwin/fhandler/proc.cc b/winsup/cygwin/fhandler/proc.cc
> index cbc49a12a417..be107cb8eacc 100644
> --- a/winsup/cygwin/fhandler/proc.cc
> +++ b/winsup/cygwin/fhandler/proc.cc
> @@ -1652,7 +1652,7 @@ format_proc_cpuinfo (void *, char *&destbuf)
>  /*	  ftcprint (features2, 11, "sev_64b");*//* SEV 64 bit host guest only */
>  /*	  ftcprint (features2, 12, "sev_rest_inj");   *//* SEV restricted injection */
>  /*	  ftcprint (features2, 13, "sev_alt_inj");    *//* SEV alternate injection */
> -/*	  ftcprint (features2, 14, "sev_es_dbg_swap");*//* SEV-ES debug state swap */
> +	  ftcprint (features2, 14, "debug_swap");   /* SEV-ES full debug state swap */
>  /*	  ftcprint (features2, 15, "no_host_ibs");    *//* host IBS unsupported */
>  /*	  ftcprint (features2, 16, "vte");    *//* virtual transparent encryption */
>  	}
> -- 
> 2.39.0