From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: Christian Franke <Christian.Franke@t-online.de>
Cc: cygwin-patches@cygwin.com
Subject: Re: [PATCH] Cygwin: Add /dev/disk/by-id symlinks
Date: Fri, 3 Nov 2023 11:09:42 +0100 [thread overview]
Message-ID: <ZUTG5lqjvknVC9ri@calimero.vinschen.de> (raw)
In-Reply-To: <ZUTDd9BH4iysokAl@calimero.vinschen.de>
On Nov 3 10:55, Corinna Vinschen wrote:
> Hi Christian,
>
> On Oct 3 14:39, Christian Franke wrote:
> > Christian Franke wrote:
> > > This is a first attempt to partly emulate the Linux directory
> > > /dev/disk/by-id. Useful to make sure the correct device is accessed in
> > > conjunction with dd, ddrescue, fdisk, ....
> >
> > Attached is the second attempt.
> >
> >
> > > The additional '*-partN' links to partitions are not yet included.
> >
> > These are now included.
> >
> >
> > > This only works properly if Win32 path '\\.\PhysicalDriveN' is always
> > > trivially mapped to NT path '\Device\HarddiskN\Partition0'.
> > > IOCTL_STORAGE_QUERY_PROPERTY with a handle from NtOpenFile(.,
> > > READ_CONTROL,...) instead of CreateFile(., 0, ...) did not work with all
> > > drivers. With stornvme.sys, it fails with permission denied. Perhaps
> > > other permission bits are required for NtOpenFile(). Thanks for any info
> > > regarding this.
> >
> > According to NtQueryObject(., ObjectBasicInformation, ...), using
> > NtOpenFile(., MAXIMUM_ALLOWED, ...) without admin rights sets GrantedAccess
> > to 0x001200a0 (FILE_EXECUTE|FILE_READ_ATTRIBUTES|READ_CONTROL|SYNCHRONIZE).
> > For some unknown reason, NVMe drives behind stornvme.sys additionally
> > require SYNCHRONIZE to use IOCTL_STORAGE_QUERY_PROPERTY. Possibly a harmless
> > bug in the access check somewhere in the NVMe stack.
> >
> > The disk scanning from the first patch has been reworked based on code
> > borrowed from proc.cc:format_proc_partitions(). For the longer term, it may
> > make sense to provide one flexible scanning function for /dev/sdXN,
> > /proc/partitions and /proc/disk/by-id.
>
> I applied your patch locally (patch looks pretty well, btw) but found
> that /dev/disk/by-id is empty, even when running with admin rights.
>
> I ran this on Windows 11 and Windows 2K19 in a QEMU/KVM VM. A
> \Device\Harddisk0\Partition0 symlink pointing to \Device\Harddisk0\DR0
> exists in both cases. I straced it, and found the following debug
> output:
>
> 1015 1155432 [main] ls 361 stordesc_to_id_name: Harddisk0\Partition0: 'Red_Hat' 'VirtIO' '' (ignored)
>
> Is that really desired?
Thread 1 "ls" hit Breakpoint 2, stordesc_to_id_name (upath=0x7ffffc500,
ioctl_buf=0x10e0720 "(", name=...)
at /home/corinna/src/cygwin/vanilla/winsup/cygwin/fhandler/dev_disk.cc:44
44 const STORAGE_DEVICE_DESCRIPTOR *desc =
(gdb) n
47 int vendor_len = 0, product_len = 0, serial_len = 0;
(gdb)
48 if (desc->VendorIdOffset)
(gdb)
49 vendor_len = sanitize_id_string (ioctl_buf + desc->VendorIdOffset);
(gdb)
50 if (desc->ProductIdOffset)
(gdb)
51 product_len = sanitize_id_string (ioctl_buf + desc->ProductIdOffset);
(gdb)
52 if (desc->SerialNumberOffset)
(gdb)
53 serial_len = sanitize_id_string (ioctl_buf + desc->SerialNumberOffset);
(gdb)
55 bool valid = (4 <= vendor_len + product_len && 4 <= serial_len
(gdb) p vendor_len
$1 = 7
(gdb) p product_len
$2 = 6
(gdb) p serial_len
$3 = 0
(gdb) n
[New Thread 3944.0x1958]
56 && (20 + vendor_len + 1 + product_len + 1 + serial_len + 10)
(gdb) n
55 bool valid = (4 <= vendor_len + product_len && 4 <= serial_len
(gdb)
55 bool valid = (4 <= vendor_len + product_len && 4 <= serial_len
(gdb)
58 debug_printf ("%S: '%s' '%s' '%s'%s", upath,
(gdb) p valid
$4 = false
HTH,
Corinna
next prev parent reply other threads:[~2023-11-03 10:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 11:57 Christian Franke
2023-10-03 12:39 ` Christian Franke
2023-11-03 9:55 ` Corinna Vinschen
2023-11-03 10:09 ` Corinna Vinschen [this message]
2023-11-03 11:06 ` Christian Franke
2023-11-03 11:11 ` Corinna Vinschen
2023-11-03 11:10 ` Corinna Vinschen
2023-11-03 13:27 ` Corinna Vinschen
2023-11-03 16:09 ` Christian Franke
2023-11-03 16:27 ` Corinna Vinschen
2023-11-03 16:30 ` Corinna Vinschen
2023-11-03 17:54 ` Christian Franke
2023-11-04 9:34 ` Corinna Vinschen
2023-11-04 9:57 ` Corinna Vinschen
2023-11-04 11:34 ` Christian Franke
2023-11-04 15:53 ` Christian Franke
2023-11-04 20:51 ` Corinna Vinschen
2023-11-05 15:45 ` Christian Franke
2023-11-05 19:59 ` Corinna Vinschen
2023-11-07 10:10 ` Christian Franke
2023-11-07 13:29 ` Corinna Vinschen
2023-11-07 14:30 ` Christian Franke
2023-11-07 15:23 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUTG5lqjvknVC9ri@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=Christian.Franke@t-online.de \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).