From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] Cygwin: pthread: Fix handle leak in pthread_once.
Date: Wed, 24 Jan 2024 15:40:22 +0100 [thread overview]
Message-ID: <ZbEhVg3ApRhrWF1Z@calimero.vinschen.de> (raw)
In-Reply-To: <20240124134448.39071-1-takashi.yano@nifty.ne.jp>
On Jan 24 22:44, Takashi Yano wrote:
> If pthread_once() is called with pthread_once_t initialized using
> PTREAD_ONCE_INIT, pthread_once does not release pthread_mutex used
> internally. This patch fixes that by calling pthread_mutex_destroy()
> in the thread which has called init_routine.
>
> Reviewed-by: Corinna Vinschen <corinna@vinschen.de>
> Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
> ---
> winsup/cygwin/thread.cc | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/winsup/cygwin/thread.cc b/winsup/cygwin/thread.cc
> index 7bb4f9fc8..0f8327831 100644
> --- a/winsup/cygwin/thread.cc
> +++ b/winsup/cygwin/thread.cc
> @@ -2060,6 +2060,9 @@ pthread::once (pthread_once_t *once_control, void (*init_routine) (void))
> {
> init_routine ();
> once_control->state = 1;
> + pthread_mutex_unlock (&once_control->mutex);
> + while (pthread_mutex_destroy (&once_control->mutex) == EBUSY);
> + return 0;
> }
> /* Here we must remove our cancellation handler */
> pthread_mutex_unlock (&once_control->mutex);
> --
> 2.43.0
Sure, please push.
(You don't have to CC me, btw., I only get the same mail twice then
and I look into this mailing list constantly anyway)
Thanks,
Corinna
next prev parent reply other threads:[~2024-01-24 14:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 13:44 Takashi Yano
2024-01-24 14:40 ` Corinna Vinschen [this message]
2024-01-24 14:48 ` Takashi Yano
2024-01-24 15:57 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbEhVg3ApRhrWF1Z@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).