From: Jeremy Drake <cygwin@jdrake.com>
To: cygwin-patches@cygwin.com
Subject: [PATCH v2] cygwin: use CREATE_DEFAULT_ERROR_MODE in spawn
Date: Wed, 9 Dec 2020 11:27:11 -0800 (PST) [thread overview]
Message-ID: <alpine.BSO.2.21.2012091123460.9707@resin.csoft.net> (raw)
This allows native processes to get Windows-default error handling
behavior (such as invoking the registered JIT debugger).
---
winsup/cygwin/spawn.cc | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/winsup/cygwin/spawn.cc b/winsup/cygwin/spawn.cc
index 92d190d1a..83b216f52 100644
--- a/winsup/cygwin/spawn.cc
+++ b/winsup/cygwin/spawn.cc
@@ -431,6 +431,13 @@ child_info_spawn::worker (const char *prog_arg, const char *const *argv,
c_flags |= CREATE_SEPARATE_WOW_VDM | CREATE_UNICODE_ENVIRONMENT;
+ /* Add CREATE_DEFAULT_ERROR_MODE flag for non-Cygwin processes so they
+ get the default error mode instead of inheriting the mode Cygwin
+ uses. This allows things like Windows Error Reporting/JIT debugging
+ to work with processes launched from a Cygwin shell. */
+ if (!real_path.iscygexec ())
+ c_flags |= CREATE_DEFAULT_ERROR_MODE;
+
/* We're adding the CREATE_BREAKAWAY_FROM_JOB flag here to workaround
issues with the "Program Compatibility Assistant (PCA) Service".
For some reason, when starting long running sessions from mintty(*),
--
2.29.2.windows.3
next reply other threads:[~2020-12-09 19:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 19:27 Jeremy Drake [this message]
2020-12-10 9:47 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.BSO.2.21.2012091123460.9707@resin.csoft.net \
--to=cygwin@jdrake.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).