From: Brian Inglis <Brian.Inglis@SystematicSw.ab.ca>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] format_proc_swaps: ensure space between fields for clarity
Date: Fri, 30 Apr 2021 18:37:16 -0600 [thread overview]
Message-ID: <b23fbd54-67d6-61f2-44ef-43f3f8c88d86@SystematicSw.ab.ca> (raw)
In-Reply-To: <YIxVIjqTpV+5Sf7T@calimero.vinschen.de>
On 2021-04-30 13:06, Corinna Vinschen wrote:
> On Apr 30 07:19, Brian Inglis wrote:
>> page/swap space name >= 40 or size/used >= 8 leaves no space between fields;
>> ensure a space after name and add extra tabs after size and used fields;
>> output appears like Linux 5.8 after changes to mm/swapfile(swap_show);
>>
>> proc-swaps-space-before.log:
>> ==> /proc/swaps <==
>> Filename Type Size Used Priority
>> /mnt/c/pagefile.sys file 11567748292920 0
>> /mnt/d/pagefile.sys file 12582912205960 0
>>
>> proc-swaps-space-after.log:
>> ==> /proc/swaps <==
>> Filename Type Size Used Priority
>> /mnt/c/pagefile.sys file 11567748 241024 0
>> /mnt/d/pagefile.sys file 12582912 182928 0
>> ---
>> winsup/cygwin/fhandler_proc.cc | 15 ++++++++++++---
>> 1 file changed, 12 insertions(+), 3 deletions(-)
>
> Pushed.
Cheers!
Don't know how those numbers got bumped - perhaps during Windows 20H2 update?
Must have been original 8GB when updating proc(5) in docs, or I'd have noticed.
--
Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada
This email may be disturbing to some readers as it contains
too much technical detail. Reader discretion is advised.
[Data in binary units and prefixes, physical quantities in SI.]
prev parent reply other threads:[~2021-05-01 0:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 13:19 Brian Inglis
2021-04-30 19:06 ` Corinna Vinschen
2021-05-01 0:37 ` Brian Inglis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b23fbd54-67d6-61f2-44ef-43f3f8c88d86@SystematicSw.ab.ca \
--to=brian.inglis@systematicsw.ab.ca \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).