From: Ken Brown <kbrown@cornell.edu>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] Cygwin: chown: make sure ctime gets updated when necessary
Date: Mon, 25 Jan 2021 14:16:42 -0500 [thread overview]
Message-ID: <c40f388a-7afd-a672-06e3-4c92edf4060c@cornell.edu> (raw)
In-Reply-To: <20210125185730.GF4393@calimero.vinschen.de>
On 1/25/2021 1:57 PM, Corinna Vinschen via Cygwin-patches wrote:
> On Jan 25 12:24, Ken Brown via Cygwin-patches wrote:
>> Following POSIX, ensure that ctime is updated if chown succeeds,
>> unless the new owner is specified as (uid_t)-1 and the new group is
>> specified as (gid_t)-1. Previously, ctime was unchanged whenever the
>> owner and group were both unchanged.
>>
>> Aside from POSIX compliance, this fix makes gnulib report that chown
>> works on Cygwin. This improves the efficiency of packages like GNU
>> tar that use gnulib's chown module. Previously such packages would
>> use a gnulib replacement for chown on Cygwin.
>> ---
>> winsup/cygwin/fhandler_disk_file.cc | 10 +++++++++-
>> 1 file changed, 9 insertions(+), 1 deletion(-)
>>
>> diff --git a/winsup/cygwin/fhandler_disk_file.cc b/winsup/cygwin/fhandler_disk_file.cc
>> index 07f9c513a..72d259579 100644
>> --- a/winsup/cygwin/fhandler_disk_file.cc
>> +++ b/winsup/cygwin/fhandler_disk_file.cc
>> @@ -863,6 +863,7 @@ fhandler_disk_file::fchown (uid_t uid, gid_t gid)
>> tmp_pathbuf tp;
>> aclent_t *aclp;
>> int nentries;
>> + bool noop = true;
>>
>> if (!pc.has_acls ())
>> {
>> @@ -887,11 +888,18 @@ fhandler_disk_file::fchown (uid_t uid, gid_t gid)
>> aclp, MAX_ACL_ENTRIES)) < 0)
>> goto out;
>>
>> + /* According to POSIX, chown can be a no-op if uid is (uid_t)-1 and
>> + gid is (gid_t)-1. Otherwise, even if uid and gid are unchanged,
>> + we must ensure that ctime is updated. */
>> if (uid == ILLEGAL_UID)
>> uid = old_uid;
>> + else
>> + noop = false;
>> if (gid == ILLEGAL_GID)
>> gid = old_gid;
>> - if (uid == old_uid && gid == old_gid)
>
> Basically ok, but why not just
>
> if (uid == ILLEGAL_UID && gid == ILLEGAL_GID)
>
> instead of the noop var?
I went back and forth on that. Following your suggestion, the code looks like this:
if (uid == ILLEGAL_UID && gid == ILLEGAL_GID)
{
ret = 0;
goto out;
}
if (uid == ILLEGAL_UID)
uid = old_uid;
if (gid == ILLEGAL_GID)
gid = old_gid;
I was trying to avoid checking uid == ILLEGAL_UID and gid == ILLEGAL_GID twice.
But on second thought, it's probably silly to worry about that. The code is
cleaner without the noop variable.
Thanks.
Ken
next prev parent reply other threads:[~2021-01-25 19:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 17:24 Ken Brown
2021-01-25 18:57 ` Corinna Vinschen
2021-01-25 19:16 ` Ken Brown [this message]
2021-01-26 12:16 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c40f388a-7afd-a672-06e3-4c92edf4060c@cornell.edu \
--to=kbrown@cornell.edu \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).