public inbox for cygwin-patches@cygwin.com
 help / color / mirror / Atom feed
From: Jon Turney <jon.turney@dronecode.org.uk>
To: Ken Brown <kbrown@cornell.edu>,
	Cygwin Patches <cygwin-patches@cygwin.com>
Subject: Re: [PATCH] Cygwin: remove most occurrences of __stdcall, WINAPI, and, __cdecl
Date: Sun, 5 Jun 2022 21:24:15 +0100	[thread overview]
Message-ID: <c9c7e7fe-adc6-c845-2720-06bc40591255@dronecode.org.uk> (raw)
In-Reply-To: <2d54f846-365f-848f-4fdb-1c22d4c1bfa0@cornell.edu>

On 03/06/2022 15:00, Ken Brown wrote:
> remove most occurrences of __stdcall, WINAPI, and __cdecl
> 
> These have no effect on x86_64.  Retain only a few occurrences of
> __cdecl in files imported from other sources.

While you are correct that it has no effect on x86_64, I'd incline 
towards retaining WINAPI on Windows API functions, because it's part of 
the function signature.  But other people might have other opinions on 
that...

  reply	other threads:[~2022-06-05 20:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-03 14:00 Ken Brown
2022-06-05 20:24 ` Jon Turney [this message]
2022-06-05 22:23   ` Ken Brown
2022-06-06  0:02   ` Takashi Yano
2022-06-06 16:24   ` Ken Brown
2022-06-06 23:21     ` Takashi Yano
2022-06-07 16:49     ` Takashi Yano
2022-06-07 18:00       ` Ken Brown
2022-06-06 10:41 ` Jon Turney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c9c7e7fe-adc6-c845-2720-06bc40591255@dronecode.org.uk \
    --to=jon.turney@dronecode.org.uk \
    --cc=cygwin-patches@cygwin.com \
    --cc=kbrown@cornell.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).