From: Ken Brown <kbrown@cornell.edu>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] Cygwin: pipe: Suppress unnecessary set_pipe_non_blocking() call.
Date: Wed, 17 Nov 2021 10:09:19 -0500 [thread overview]
Message-ID: <ce2d178a-4a01-6041-3ca7-44a9df090222@cornell.edu> (raw)
In-Reply-To: <20211117080827.1800-1-takashi.yano@nifty.ne.jp>
On 11/17/2021 3:08 AM, Takashi Yano wrote:
> - Call set_pipe_non_blocking(false) only if the pipe will be really
> inherited to non-cygwin process.
LGTM, but Corinna should probably take a quick look too, since I'm not very
familiar with this part of the code.
Ken
next prev parent reply other threads:[~2021-11-17 15:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 8:08 Takashi Yano
2021-11-17 15:09 ` Ken Brown [this message]
2021-11-17 18:22 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce2d178a-4a01-6041-3ca7-44a9df090222@cornell.edu \
--to=kbrown@cornell.edu \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).