Re: [PATCH v2] Cygwin: Make <sys/cpuset.h> safe for c89 compilations

[Mark Geisert <mark@maxrnd.com>]

Corinna Vinschen wrote:
> On Jul  4 16:33, Corinna Vinschen wrote:
>> On Jul  3 17:51, Mark Geisert wrote:
>>> Four modifications to include/sys/cpuset.h:
>>> * Change C++-style comments to C-style also supported by C++
>>> * Change "inline" to "__inline" on code lines
>>> * Add "#include <sys/cdefs.h>" to make sure __inline is defined
>>> * Don't declare loop variables on for-loop init clauses
>>>
>>> Tested by first reproducing the reported issue with home-grown test
>>> programs by compiling with gcc option "-std=c89", then compiling again
>>> using the modified <sys/cpuset.h>. Other "-std=" options tested too.
>>>
>>> Addresses: https://cygwin.com/pipermail/cygwin-patches/2023q3/012308.html
>>> Fixes: 315e5fbd99ec ("Cygwin: Fix type mismatch on sys/cpuset.h")
>>> Signed-off-by: Mark Geisert <mark@maxrnd.com>
>>>
>>> ---
>>>   winsup/cygwin/include/sys/cpuset.h | 49 ++++++++++++++++--------------
>>>   winsup/cygwin/release/3.4.7        |  3 ++
>>>   2 files changed, 30 insertions(+), 22 deletions(-)
>>
>> Pushed.
> 
> FYI, I missed to notice that you added the release message to the
> already existing 3.4.7 release.  I moved it into a new file for 3.4.8.

Thank you for cleaning up after my goof on the version.
Cheers & Regards,

..mark