public inbox for cygwin-patches@cygwin.com
 help / color / mirror / Atom feed
From: Ken Brown <kbrown@cornell.edu>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] Cygwin: connect: implement resetting a connected DGRAM socket
Date: Tue, 27 Apr 2021 09:48:36 -0400	[thread overview]
Message-ID: <f46d381d-07bd-98eb-cfb0-e87f29dc8f8a@cornell.edu> (raw)
In-Reply-To: <YIgPbG6NoGqxyrAI@calimero.vinschen.de>

On 4/27/2021 9:19 AM, Corinna Vinschen wrote:
> On Apr 26 15:37, Ken Brown wrote:
>> Following POSIX and Linux, allow a connected DGRAM socket's connection
>> to be reset (so that the socket becomes unconnected).  This is done by
>> calling connect and specifing an address whose family is AF_UNSPEC.
>> ---
>>   winsup/cygwin/fhandler_socket_inet.cc  | 21 ++++++++++++++++--
>>   winsup/cygwin/fhandler_socket_local.cc | 30 +++++++++++++++++++++-----
>>   winsup/cygwin/fhandler_socket_unix.cc  |  7 ++++++
>>   winsup/cygwin/release/3.2.1            |  3 +++
>>   winsup/doc/new-features.xml            |  6 ++++++
>>   5 files changed, 60 insertions(+), 7 deletions(-)
> 
> LGTM.
> 
>> --- a/winsup/cygwin/release/3.2.1
>> +++ b/winsup/cygwin/release/3.2.1
>> @@ -1,6 +1,9 @@
>>   What's new:
>>   -----------
>>   
>> +- A connected datagram socket can now have its connection reset.  As
>> +  specified by POSIX and Linux, this is done by calling connect(2)
>> +  with an address structure whose family is AF_UNSPEC.
> 
> Isn't that just a bug, in theory?

I was thinking of it as a feature that hadn't been implemented yet.  But on 
second thought, I agree with you.  I'll change that.

Ken

      reply	other threads:[~2021-04-27 13:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-26 19:37 Ken Brown
2021-04-27 13:19 ` Corinna Vinschen
2021-04-27 13:48   ` Ken Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f46d381d-07bd-98eb-cfb0-e87f29dc8f8a@cornell.edu \
    --to=kbrown@cornell.edu \
    --cc=cygwin-patches@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).