From: Christian Franke <Christian.Franke@t-online.de>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH rebase] Add support for Compact OS compression for Cygwin
Date: Thu, 14 Jul 2022 16:41:43 +0200 [thread overview]
Message-ID: <f8f4e3af-c39b-415a-7d6e-5e9a7aa07162@t-online.de> (raw)
In-Reply-To: <YtAoF7HvCTw177IB@calimero.vinschen.de>
Corinna Vinschen wrote:
> On Jul 14 14:12, Christian Franke wrote:
>
>>>> +#endif
>>> This ifdef still makes sense, of course ...
>> Could possibly also be enhanced to __MSYS__ and msys1.dll.
> Not sure this makes sense. Does their installer support CompactOS?
No, AFIAK. Then only (nonexistent?) users who run 'compact /c /exe:lzx
...' manually on their installation would benefit.
>>
>>> ... and on first glance, the
>>> remainder of the patch LGTM.
>> Thanks. Attached is an alternative patch with most ifdefs removed.
> LGTM. I'm not going to push it, yet, because... do you still want to
> add the aforementioned MSYS support? If not, I'll just go ahead.
Please go ahead. I don't want to add platform specific code not actually
tested on that platform.
Thanks,
Christian
next prev parent reply other threads:[~2022-07-14 14:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 10:02 Christian Franke
2022-07-14 10:24 ` Corinna Vinschen
2022-07-14 12:12 ` Christian Franke
2022-07-14 14:28 ` Corinna Vinschen
2022-07-14 14:41 ` Christian Franke [this message]
2022-07-14 14:54 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8f4e3af-c39b-415a-7d6e-5e9a7aa07162@t-online.de \
--to=christian.franke@t-online.de \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).