From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31919 invoked by alias); 23 Dec 2003 20:19:53 -0000 Mailing-List: contact cygwin-xfree-help@cygwin.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-xfree-owner@cygwin.com Mail-Followup-To: cygwin-xfree@cygwin.com Reply-To: cygwin-xfree@cygwin.com Received: (qmail 31908 invoked from network); 23 Dec 2003 20:19:47 -0000 Received: from unknown (HELO sccrmhc12.comcast.net) (204.127.202.56) by sources.redhat.com with SMTP; 23 Dec 2003 20:19:47 -0000 Received: from [192.168.0.103] (12-231-141-5.client.attbi.com[12.231.141.5]) by comcast.net (sccrmhc12) with SMTP id <2003122320194601200r4dnoe>; Tue, 23 Dec 2003 20:19:46 +0000 Subject: Re: Proper attribution of patches From: Eric Anholt To: devel@XFree86.Org Cc: cygwin-xfree@cygwin.com In-Reply-To: References: <200312222110.hBMLAPRo087003@public.xfree86.org> <3FE888B0.2020503@msu.edu> <3FE894EE.2090103@msu.edu> Content-Type: text/plain Message-Id: <1072210853.814.33.camel@leguin> Mime-Version: 1.0 Date: Tue, 23 Dec 2003 20:45:00 -0000 Content-Transfer-Encoding: 7bit X-SW-Source: 2003-12/txt/msg00337.txt.bz2 List-Id: On Tue, 2003-12-23 at 11:32, Thomas Dickey wrote: > On Tue, 23 Dec 2003, Harold L Hunt II wrote: > > > XFree86 should be taking care not to steal credit for our patches by > > committing them without proper attribution. > > your standards are inconsistent: your committing the change rather than > offering commit access to someone who solved a problem that (according > to the email thread) that had stopped you for some _months_ indicates > that your whole aim on this is to get credit for yourself. > > I noted that the comment in the code was properly attributed, no further > action was needed. I see only minor inconsitency on his part, that the original commit of that code didn't attribute it to its author in the CVS logs, while at least some other commits do note authors of patches. However, he didn't explicitly take credit for it, like you did in the ChangeLog, and his announcement of new packages with those changes reflects the author correctly. I don't see Harold Hunt asking for his name to be on the patch in any way, only the patch's author's name (the "members of the Cygwin/X community" in the original mail). The only responsible thing for you to do would be to correct the ChangeLog to attribute it to the patch's author. -- Eric Anholt eta@lclark.edu http://people.freebsd.org/~anholt/ anholt@FreeBSD.org