public inbox for cygwin-xfree@sourceware.org
help / color / mirror / Atom feed
* Re: cygwin.rules - Enabling shared libXt finally?
@ 2003-10-21 7:43 Ralf Habacker
2003-10-21 13:10 ` Harold L Hunt II
0 siblings, 1 reply; 6+ messages in thread
From: Ralf Habacker @ 2003-10-21 7:43 UTC (permalink / raw)
To: Cygwin-Xfree@Cygwin. Com
Harold,
>It looks like you got it nailed to me. I am testing a build right now.
>
I have too additional notes to this patch.
1. Because _Xtinherit is exported as a data symbol, immediate calls to this
function in the manner
...
_XtInherit();
...
will be relocated wrongly and should be avoided ( I have seen this, but does
not know currently why this happens).
A workaround in case this is absolutly required is to use the following
stuff.
void (*func)(void);
func _blah_blah = XtInherit;
...
(*_blah_blah);
...
2. In the patch there is a symbol named "_y". This should be renamed to a
name, which couldn't be used by regular functions for example
_$Xtinherit_ref or so. The '$' isn't a valid c function name.
Ralf
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: cygwin.rules - Enabling shared libXt finally?
2003-10-21 7:43 cygwin.rules - Enabling shared libXt finally? Ralf Habacker
@ 2003-10-21 13:10 ` Harold L Hunt II
2003-10-21 18:30 ` AW: " Ralf Habacker
0 siblings, 1 reply; 6+ messages in thread
From: Harold L Hunt II @ 2003-10-21 13:10 UTC (permalink / raw)
To: cygwin-xfree
[-- Attachment #1: Type: text/plain, Size: 1136 bytes --]
Ralf,
Not sure I understand. What should be changed in the current version of
the Xt code?
Attached are my curent xc/lib/Xt/[Initialize.c|IntrinsicP.h] files.
Please send a diff against these if anything should be changed. Note
that these are intentionally from the 4.3 branch.
Thanks,
Harold
Ralf Habacker wrote:
> Harold,
>
>
>>It looks like you got it nailed to me. I am testing a build right now.
>>
>
> I have too additional notes to this patch.
>
> 1. Because _Xtinherit is exported as a data symbol, immediate calls to this
> function in the manner
>
> ...
> _XtInherit();
> ...
>
> will be relocated wrongly and should be avoided ( I have seen this, but does
> not know currently why this happens).
>
> A workaround in case this is absolutly required is to use the following
> stuff.
>
> void (*func)(void);
>
> func _blah_blah = XtInherit;
>
> ...
> (*_blah_blah);
> ...
>
> 2. In the patch there is a symbol named "_y". This should be renamed to a
> name, which couldn't be used by regular functions for example
> _$Xtinherit_ref or so. The '$' isn't a valid c function name.
>
> Ralf
>
>
>
>
>
[-- Attachment #2: Initialize_and_IntrinsicP.tar.bz2 --]
[-- Type: application/octet-stream, Size: 11822 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* AW: cygwin.rules - Enabling shared libXt finally?
2003-10-21 13:10 ` Harold L Hunt II
@ 2003-10-21 18:30 ` Ralf Habacker
2003-10-22 2:22 ` Charles Wilson
0 siblings, 1 reply; 6+ messages in thread
From: Ralf Habacker @ 2003-10-21 18:30 UTC (permalink / raw)
To: cygwin-xfree
Harold
>
> Not sure I understand. What should be changed in the current version of
> the Xt code?
only note 1, chaning the label. The second note is only for completeness.
> Attached are my curent xc/lib/Xt/[Initialize.c|IntrinsicP.h] files.
> Please send a diff against these if anything should be changed. Note
> that these are intentionally from the 4.3 branch.
>
--- Initialize-old.c 2003-10-21 20:21:18.000000000 +0200
+++ Initialize.c 2003-10-21 20:23:25.000000000 +0200
@@ -236,8 +236,8 @@
asm (".data\n\
.globl __XtInherit \n\
- __XtInherit: jmp *_$$y \n\
- _$$y: .long ___XtInherit \n\
+ __XtInherit: jmp *__$XtInherit \n\
+ __$XtInherit: .long ___XtInherit \n\
.text \n");
#define _XtInherit __XtInherit
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: AW: cygwin.rules - Enabling shared libXt finally?
2003-10-21 18:30 ` AW: " Ralf Habacker
@ 2003-10-22 2:22 ` Charles Wilson
2003-10-22 2:39 ` Harold L Hunt II
2003-10-22 17:16 ` AW: " Ralf Habacker
0 siblings, 2 replies; 6+ messages in thread
From: Charles Wilson @ 2003-10-22 2:22 UTC (permalink / raw)
To: cygwin-xfree
Errm, this isn't going to change the public interface is it? That is,
if Harold releases another libXt with this change, would that break the
recently re-compiled and released lesstif, etc etc?
--
Chuck
Ralf Habacker wrote:
>>Not sure I understand. What should be changed in the current version of
>>the Xt code?
>
>
> only note 1, chaning the label. The second note is only for completeness.
>
>
>
>>Attached are my curent xc/lib/Xt/[Initialize.c|IntrinsicP.h] files.
>>Please send a diff against these if anything should be changed. Note
>>that these are intentionally from the 4.3 branch.
>>
>
> --- Initialize-old.c 2003-10-21 20:21:18.000000000 +0200
> +++ Initialize.c 2003-10-21 20:23:25.000000000 +0200
> @@ -236,8 +236,8 @@
>
> asm (".data\n\
> .globl __XtInherit \n\
> - __XtInherit: jmp *_$$y \n\
> - _$$y: .long ___XtInherit \n\
> + __XtInherit: jmp *__$XtInherit \n\
> + __$XtInherit: .long ___XtInherit \n\
> .text \n");
>
> #define _XtInherit __XtInherit
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: AW: cygwin.rules - Enabling shared libXt finally?
2003-10-22 2:22 ` Charles Wilson
@ 2003-10-22 2:39 ` Harold L Hunt II
2003-10-22 17:16 ` AW: " Ralf Habacker
1 sibling, 0 replies; 6+ messages in thread
From: Harold L Hunt II @ 2003-10-22 2:39 UTC (permalink / raw)
To: cygwin-xfree
I would be okay with that if it happened. I am the one that recompiled
lesstif and I don't think that the maintainers of other Xt-dependent
apps have recompiled yet.
However, if it isn't a big deal then I will wait until the 4.4.0 release
to make this change. 4.4.0 should be released around December some time.
Harold
Charles Wilson wrote:
> Errm, this isn't going to change the public interface is it? That is,
> if Harold releases another libXt with this change, would that break the
> recently re-compiled and released lesstif, etc etc?
>
> --
> Chuck
>
> Ralf Habacker wrote:
>
>>> Not sure I understand. What should be changed in the current version
>>> of the Xt code?
>>
>>
>>
>> only note 1, chaning the label. The second note is only for completeness.
>>
>>
>>> Attached are my curent xc/lib/Xt/[Initialize.c|IntrinsicP.h] files.
>>> Please send a diff against these if anything should be changed. Note
>>> that these are intentionally from the 4.3 branch.
>>>
>>
>> --- Initialize-old.c 2003-10-21 20:21:18.000000000 +0200
>> +++ Initialize.c 2003-10-21 20:23:25.000000000 +0200
>> @@ -236,8 +236,8 @@
>>
>> asm (".data\n\
>> .globl __XtInherit \n\
>> - __XtInherit: jmp *_$$y \n\
>> - _$$y: .long ___XtInherit \n\
>> + __XtInherit: jmp *__$XtInherit \n\
>> + __$XtInherit: .long ___XtInherit \n\
>> .text \n");
>>
>> #define _XtInherit __XtInherit
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* AW: AW: cygwin.rules - Enabling shared libXt finally?
2003-10-22 2:22 ` Charles Wilson
2003-10-22 2:39 ` Harold L Hunt II
@ 2003-10-22 17:16 ` Ralf Habacker
1 sibling, 0 replies; 6+ messages in thread
From: Ralf Habacker @ 2003-10-22 17:16 UTC (permalink / raw)
To: cygwin-xfree
No,
there is no functional changes. I only want to make sure, that no c function
in Intrinsic.c can use the symbol _y (in c 'y'),
so this patch renames it to __$XtInherit, which isn't usable for c
functions.
BTW: I was very in rush while doing the last patch, which may fails to be
applied. The symbol which has to be patched is _y and not _$$y like done in
the previous patch. I've added an updated patch.
Ralf
--- Initialize-old.c 2003-10-21 20:21:18.000000000 +0200
+++ Initialize.c 2003-10-21 20:23:25.000000000 +0200
@@ -236,8 +236,8 @@
asm (".data\n\
.globl __XtInherit \n\
- __XtInherit: jmp *_y \n\
- _y: .long ___XtInherit \n\
+ __XtInherit: jmp *__$XtInherit \n\
+ __$XtInherit: .long ___XtInherit \n\
.text \n");
#define _XtInherit __XtInherit
Ralf
>
> Errm, this isn't going to change the public interface is it? That is,
> if Harold releases another libXt with this change, would that break the
> recently re-compiled and released lesstif, etc etc?
>
> --
> Chuck
>
> Ralf Habacker wrote:
>
> >>Not sure I understand. What should be changed in the current
> version of
> >>the Xt code?
> >
> >
> > only note 1, chaning the label. The second note is only for
> completeness.
> >
> >
> >
> >>Attached are my curent xc/lib/Xt/[Initialize.c|IntrinsicP.h] files.
> >>Please send a diff against these if anything should be changed. Note
> >>that these are intentionally from the 4.3 branch.
> >>
> >
> > --- Initialize-old.c 2003-10-21 20:21:18.000000000 +0200
> > +++ Initialize.c 2003-10-21 20:23:25.000000000 +0200
> > @@ -236,8 +236,8 @@
> >
> > asm (".data\n\
> > .globl __XtInherit \n\
> > - __XtInherit: jmp *_$$y \n\
> > - _$$y: .long ___XtInherit \n\
> > + __XtInherit: jmp *__$XtInherit \n\
> > + __$XtInherit: .long ___XtInherit \n\
> > .text \n");
> >
> > #define _XtInherit __XtInherit
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2003-10-22 17:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-10-21 7:43 cygwin.rules - Enabling shared libXt finally? Ralf Habacker
2003-10-21 13:10 ` Harold L Hunt II
2003-10-21 18:30 ` AW: " Ralf Habacker
2003-10-22 2:22 ` Charles Wilson
2003-10-22 2:39 ` Harold L Hunt II
2003-10-22 17:16 ` AW: " Ralf Habacker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).