From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11287 invoked by alias); 3 Nov 2003 14:30:17 -0000 Mailing-List: contact cygwin-xfree-help@cygwin.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-xfree-owner@cygwin.com Mail-Followup-To: cygwin-xfree@cygwin.com Reply-To: cygwin-xfree@cygwin.com Received: (qmail 11279 invoked from network); 3 Nov 2003 14:30:15 -0000 Received: from unknown (HELO sys09.mail.msu.edu) (35.9.75.109) by sources.redhat.com with SMTP; 3 Nov 2003 14:30:15 -0000 Received: from office.ixn.com ([68.23.74.57] helo=msu.edu) by sys09.mail.msu.edu with asmtp (Exim 4.10 #3) (TLSv1:RC4-MD5:128) id 1AGfig-0005r0-00 for cygwin-xfree@cygwin.com; Mon, 03 Nov 2003 09:30:14 -0500 Message-ID: <3FA66674.6080900@msu.edu> Date: Mon, 03 Nov 2003 14:30:00 -0000 From: Harold L Hunt II User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5) Gecko/20031013 Thunderbird/0.3 X-Accept-Language: en-us, en MIME-Version: 1.0 To: cygwin-xfree@cygwin.com Subject: Re: Patch for keyboard handling References: <20031103163010.840F.MURAKAMI@ipl.t.u-tokyo.ac.jp> In-Reply-To: <20031103163010.840F.MURAKAMI@ipl.t.u-tokyo.ac.jp> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-11/txt/msg00024.txt.bz2 List-Id: Takuma Murakami wrote: > I have made a patch to improve keyboard handling. > Any comments would be appreciated. > > The changes are: > > 1) win.h, winkeybd.c, winwndproc.c - Improve the > synchronization of mode key states between XWin > and Windows. + /* Stored to get internal mode key states. Must be read-only. */ + static unsigned short *g_winInternalModeKeyStatesPtr = NULL; Shouldn't this be a pointer to constant data? Isn't that: static unsigned short const * g_winInternalModeKeyStatesPtr = NULL; ??? > 2) winmultiwindowwndproc.c - Enable mode key > synchronization in -multiwindow mode. + g_winInternalModeKeyStatesPtr = &(pDeviceInt->key->state); Wow! That is a really good idea. I should have been doing that all along, but I didn't realize that I could access the internal mode-key states. Great idea. > 3) winwndproc.c - Make clean termination on > logoff or shutdown. Good catch for WM_ENDSESSION. That should have been there all along... > 4) winconfig.c - Fix the lacks of KEYUP messages in > Japanese environments. The solution was proposed > by Kensuke Matsuzaki. Looks good to me. It all depends on if it works for you guys. > 5) winwndproc.c - Ignore Windows keyboard auto-repeats > so that XWin controls auto-repeats instead of Windows. Okay. I will try to apply this patch tomorrow. Thanks for contributing, Harold