From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20795 invoked by alias); 21 Jul 2010 19:07:48 -0000 Received: (qmail 20784 invoked by uid 22791); 21 Jul 2010 19:07:47 -0000 X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 tests=AWL,BAYES_50,RCVD_IN_DNSWL_LOW,TW_DW X-Spam-Check-By: sourceware.org Received: from smtpout.karoo.kcom.com (HELO smtpout.karoo.kcom.com) (212.50.160.34) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 21 Jul 2010 19:07:42 +0000 Received: from 213-152-38-55.dsl.eclipse.net.uk (HELO [192.168.0.16]) ([213.152.38.55]) by smtpout.karoo.kcom.com with ESMTP; 21 Jul 2010 20:07:39 +0100 Message-ID: <4C474580.3090309@dronecode.org.uk> Date: Wed, 21 Jul 2010 19:07:00 -0000 From: Jon TURNEY Reply-To: cygwin-xfree@cygwin.com User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.11) Gecko/20100711 Thunderbird/3.0.6 MIME-Version: 1.0 To: cygwin-xfree@cygwin.com, richard.evans@datanomic.com Subject: Re: Mouse offset when using java swing based gui applications References: <4C3F0F49.5090506@dronecode.org.uk> <974066EF77EEA44EB8AED6ADA05DBD0201FFDEFB@THHS2EXBE1X.hostedservice2.net> <4C447495.5000707@dronecode.org.uk> <974066EF77EEA44EB8AED6ADA05DBD0201FFE516@THHS2EXBE1X.hostedservice2.net> In-Reply-To: <974066EF77EEA44EB8AED6ADA05DBD0201FFE516@THHS2EXBE1X.hostedservice2.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact cygwin-xfree-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-xfree-owner@cygwin.com Reply-To: cygwin-xfree@cygwin.com Mail-Followup-To: cygwin-xfree@cygwin.com X-SW-Source: 2010-07/txt/msg00079.txt.bz2 On 19/07/2010 17:27, Richard Evans wrote: > I've attached a small test case which shows the menu problems. Thanks very much, that was very helpful in investigating this problem. > This menu behaviour has been seen for all versions of JDK 1.6 as far as > I remember; it certainly happens with 1.6u3 and 1.6u4. Yes, I wasn't testing what I thought I was testing, and was completely wrong when I said sun bug #6434227 was fixed in the JRE that it claims it's fixed in. It's fixed in JDK1.7 and OpenJDK, but that bug lies when it says the fix is in 1.6 as well. However, it does identify what's going wrong. The significant difference in XDecoratedPeer.java between 1.6u21 and a fixed version is: --- /opt/wip/jdk-1_6_0/j2se/src/solaris/classes/sun/awt/X11/XDecoratedPeer.java 2010-07-21 15:46:33.281250000 +0100 +++ /opt/wip/openjdk/jdk/src/solaris/classes/sun/awt/X11/XDecoratedPeer.java 2010-06-21 22:15:43.000000000 +0100 @@ -752,79 +748,69 @@ Point newLocation = targetBounds.getLocation(); - if (xe.get_send_event()) { + if (xe.get_send_event() || runningWM == XWM.NO_WM || XWM.isNonReparentingWM()) { // Location, Client size + insets newLocation = new Point(xe.get_x() - currentInsets.left, xe.get_y() - currentInsets.top); } else { // CDE/MWM/Metacity/Sawfish bug: if shell is resized using // top or left border, we don't receive synthetic // ConfigureNotify, only the one from X with zero // coordinates. This is the workaround to get real // location, 6261336 - // Do the same for non-reparenting WMs (Compiz, Looking Glass) switch (XWM.getWMID()) { case XWM.CDE_WM: case XWM.MOTIF_WM: case XWM.METACITY_WM: case XWM.SAWFISH_WM: - case XWM.COMPIZ_WM: - case XWM.LG3D_WM: { Point xlocation = queryXLocation(); if (log.isLoggable(Level.FINE)) { log.log(Level.FINE, "New X location: {0}", new Object[]{String.valueOf(xlocation)}); } if (xlocation != null) { newLocation = xlocation; } break; } default: break; } } Location updates from ConfigureNotify are not processed in the NO_WM case, presumably causing the menus behave as if the window was still located where it was created. There are 2 possible workarounds which occur to me: (i) Lie and pretend we are a non-reparenting WM on the list that AWT knows about, like LG3D. This one of the workarounds suggested in the manpage for dwm (a non-reparenting, tiling WM) Unfortunately, we have to tell a more lies to get AWT to accept this lie, and in particular, we have to claim to support EWMH, which the internal WM doesn't really (although it should), so I'm not too keen on this approach. (ii) Alternatively, it's a straightforward workaround to add to the internal WM to cause it to send synthetic ConfigureNotify for these windows when a non-synthetic ConfigureNotify occurs. From a quick test, this approach seems to work ok. But the Java window still appears with the frame off the top-left, rather than getting nudged away from the origin so the frame is visible, which is rather mysterious. I've uploaded a build with this change at [1], patch to follow. Perhaps you could try it out and see if it works for you? [1] ftp://cygwin.com/pub/cygwinx/XWin.20100721-git-2704058015f198ce.exe.bz2 -- Jon TURNEY Volunteer Cygwin/X X Server maintainer -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Problem reports: http://cygwin.com/problems.html Documentation: http://x.cygwin.com/docs/ FAQ: http://x.cygwin.com/docs/faq/