public inbox for cygwin-xfree@sourceware.org help / color / mirror / Atom feed
From: Oliver Schmidt <oschmidt-mailinglists@gmx.de> To: cygwin-xfree@cygwin.com Subject: considering modifier keys after gaining focus Date: Tue, 16 Aug 2011 15:31:00 -0000 [thread overview] Message-ID: <4E4A8D56.6010704@gmx.de> (raw) [-- Attachment #1: Type: text/plain, Size: 1076 bytes --] Hi, I had the problem, that the state of the modifier keys was lost when a window is created (or raised). Example: in window A Ctrl + some key opens a window B, then in window B Ctrl + some other key triggers the next action. However after the opening of window B the Ctrl key has to be released and pressed again. If the user keeps the Ctrl key holding when the window B is opened, the next key press X will be interpreted as X and not as Ctrl+X. I send a patch to fix this problem with this email: I just extended the function winRestoreModeKeyStates in winkeybd.c to consider not only the mode switch key but also the modifiers Ctrl, Shift, Alt/AltGr by using the Windows function GetAsyncKeyState. This patch works fine for me. However one problem is unsolved: if the key combination for opening window B (in the above example) is an AltGr key combination, the GetAsyncKeyState will also report, that the Ctrl key is pressed, which is not true, since this is the well known Windows fake Ctrl_L :-( Any suggestions how to solve this? Best regards, Oliver [-- Attachment #2: diff03.txt --] [-- Type: text/plain, Size: 1675 bytes --] diff --git a/cygwin/hw/xwin/winkeybd.c b/cygwin/hw/xwin/winkeybd.c index 9e5a9b0..e807fc5 100644 --- a/cygwin/hw/xwin/winkeybd.c +++ b/cygwin/hw/xwin/winkeybd.c @@ -255,6 +255,7 @@ void winRestoreModeKeyStates (void) { DWORD dwKeyState; + BOOL modifierPressed; BOOL processEvents = TRUE; unsigned short internalKeyStates; @@ -282,6 +283,34 @@ winRestoreModeKeyStates (void) * have a logical XOR operator, so we use a macro instead. */ + modifierPressed = (GetAsyncKeyState (VK_CONTROL) < 0); + if (WIN_XOR (internalKeyStates & ControlMask, modifierPressed)) + { + if (modifierPressed) winSendKeyEvent (KEY_LCtrl, TRUE); + else winSendKeyEvent (KEY_LCtrl, FALSE); + } + + modifierPressed = (GetAsyncKeyState (VK_SHIFT) < 0); + if (WIN_XOR (internalKeyStates & ShiftMask, modifierPressed)) + { + if (modifierPressed) winSendKeyEvent (KEY_ShiftL, TRUE); + else winSendKeyEvent (KEY_ShiftL, FALSE); + } + + modifierPressed = (GetAsyncKeyState (VK_LMENU) < 0); + if (WIN_XOR (internalKeyStates & Mod1Mask, modifierPressed)) + { + if (modifierPressed) winSendKeyEvent (KEY_Alt, TRUE); + else winSendKeyEvent (KEY_Alt, FALSE); + } + + modifierPressed = (GetAsyncKeyState (VK_RMENU) < 0); + if (WIN_XOR (internalKeyStates & Mod5Mask, modifierPressed)) + { + if (modifierPressed) winSendKeyEvent (KEY_AltLang, TRUE); + else winSendKeyEvent (KEY_AltLang, FALSE); + } + /* Has the key state changed? */ dwKeyState = GetKeyState (VK_NUMLOCK) & 0x0001; if (WIN_XOR (internalKeyStates & NumLockMask, dwKeyState)) [-- Attachment #3: Type: text/plain, Size: 223 bytes --] -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Problem reports: http://cygwin.com/problems.html Documentation: http://x.cygwin.com/docs/ FAQ: http://x.cygwin.com/docs/faq/
next reply other threads:[~2011-08-16 15:31 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-08-16 15:31 Oliver Schmidt [this message] 2011-08-21 8:44 ` Corinna Vinschen 2011-08-21 10:04 ` Oliver Schmidt 2012-01-08 15:23 ` Oliver Schmidt 2012-01-09 14:06 ` Jon TURNEY 2012-01-09 18:11 ` Oliver Schmidt 2012-01-10 9:47 ` Oliver Schmidt 2012-01-10 10:15 ` Oliver Schmidt 2012-01-11 17:16 ` Jon TURNEY 2012-01-12 12:19 ` Oliver Schmidt 2012-01-12 12:38 ` Oliver Schmidt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4E4A8D56.6010704@gmx.de \ --to=oschmidt-mailinglists@gmx.de \ --cc=cygwin-xfree@cygwin.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).