From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25138 invoked by alias); 3 Nov 2011 19:18:25 -0000 Received: (qmail 25091 invoked by uid 22791); 3 Nov 2011 19:18:24 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,TW_BX,TW_IB,TW_KB,TW_XC,TW_XK X-Spam-Check-By: sourceware.org Received: from smtpout.karoo.kcom.com (HELO smtpout.karoo.kcom.com) (212.50.160.34) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 03 Nov 2011 19:18:09 +0000 Received: from 213-152-38-55.dsl.eclipse.net.uk (HELO [192.168.0.9]) ([213.152.38.55]) by smtpout.karoo.kcom.com with ESMTP; 03 Nov 2011 19:18:07 +0000 Message-ID: <4EB2E8FE.6020305@dronecode.org.uk> Date: Thu, 03 Nov 2011 19:18:00 -0000 From: Jon TURNEY Reply-To: cygwin-xfree User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:8.0) Gecko/20111101 Thunderbird/8.0 MIME-Version: 1.0 To: cygwin-xfree@cygwin.com CC: rpavlik@iastate.edu Subject: Re: Built XWin on mingw - with patches References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact cygwin-xfree-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-xfree-owner@cygwin.com Reply-To: cygwin-xfree@cygwin.com Mail-Followup-To: cygwin-xfree@cygwin.com X-SW-Source: 2011-11/txt/msg00006.txt.bz2 On 01/11/2011 20:39, Ryan Pavlik wrote: > Not sure if this is the right forum for this, but it seemed more This is absolutely the correct list. Thanks very much for putting in the effort to do this. > specific and probably more appropriate than the overall xorg lists. > I wanted to build a native windows X server (essentially an > open-source Xming). I had to patch a number of the packages along the > way, but did eventually arrive at a build that worked. I looked at > and used a few of the Xming patches, but only generally went to those > when the naive approach didn't work. This may be a problem. The material on the Xming website is licensed under a Creative Commons license, which is not compatible with the X11 license. So, patches from the Xming website are not acceptable unless the author has agreed to re-license them appropriately. > I'm looking for some feedback on the patches so that they can get into > the main line of the projects. > > I built using mingw-cross-env, with my fork here that includes the > dependency packages: https://bitbucket.org/rpavlik/mingw-cross-env/ > This builds everything except the xorg-server module (ignore the fact > there's an xorg-server makefile there - the patches aren't up to date > for that module.) > > Patches for these dependencies are as follows, in that mingw-cross-env > repo (These should all have commit messages from being exported from > git format-patch): > libX11-1-add-xwinsock-include, libX11-2-windows-threads, > libX11-3-MinGW-lacks-caddr_t > libXaw-1-need-winsock > libXfont-1-dummy-readlink > libxcb-1-fix-include-order-with-Xdmcp, libxcb-2-wsastartup - this last > one fixes running libX11 apps built for Windows, including the > integrated multi-window WM. > xkbcomp-1-Use-X11-Xwindows.h, xkbcomp-2-Look-in-windows-base-dir-too - > this last one supports the "RELOCATE_PROJECTROOT" option in the XWin > server - should still work fine in the normal case though. I've quickly looked over these patches and in general they look good, and I'd be happy to help get them merged upstream. A couple of general points I'd make though: It helps a great deal in reviewing if the comments state why the change is a good idea (e.g. what problem it fixes), rather than just describing the change which is made. I also noticed that a bit more care might be needed with the define you are using to enable platform specific code: WIN32 and __MINGW__ should not be used interchangeably. WIN32 will also be defined when building VcXsrv, and neither is defined on Cygwin. So, can you post your patches here, preferably in git-send-email format so we can review them in detail? -- Jon TURNEY Volunteer Cygwin/X X Server maintainer -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Problem reports: http://cygwin.com/problems.html Documentation: http://x.cygwin.com/docs/ FAQ: http://x.cygwin.com/docs/faq/