From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8309 invoked by alias); 9 Nov 2011 18:46:14 -0000 Received: (qmail 8278 invoked by uid 22791); 9 Nov 2011 18:46:13 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from smtpout.karoo.kcom.com (HELO smtpout.karoo.kcom.com) (212.50.160.34) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 09 Nov 2011 18:45:59 +0000 Received: from 213-152-38-55.dsl.eclipse.net.uk (HELO [192.168.0.7]) ([213.152.38.55]) by smtpout.karoo.kcom.com with ESMTP; 09 Nov 2011 18:45:56 +0000 Message-ID: <4EBACA74.3090704@dronecode.org.uk> Date: Wed, 09 Nov 2011 18:46:00 -0000 From: Jon TURNEY User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:8.0) Gecko/20111103 Thunderbird/8.0 MIME-Version: 1.0 To: cygwin-xfree Subject: Re: Built XWin on mingw - with patches References: <4EB2E8FE.6020305@dronecode.org.uk> <4EB81EF8.5060107@dronecode.org.uk> <4EB83346.8090007@cwilson.fastmail.fm> In-Reply-To: <4EB83346.8090007@cwilson.fastmail.fm> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact cygwin-xfree-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-xfree-owner@cygwin.com Reply-To: cygwin-xfree@cygwin.com Mail-Followup-To: cygwin-xfree@cygwin.com X-SW-Source: 2011-11/txt/msg00017.txt.bz2 On 07/11/2011 19:36, Charles Wilson wrote: > On 11/7/2011 1:10 PM, Jon TURNEY wrote: >> I see what you are trying to do here, but I'm not sure it actually adds >> any clarity. >> >> I think I'd just prefer to assume the knowledge that WIN32 and CYGWIN >> are mutually exclusive, so '#if defined(WIN32)&& !defined(__CYGWIN__)' >> can just be written '#ifdef WIN32' > > But this isn't true if you ever #include any of the w32api headers. Then > you get WIN32 defined, even on cygwin... True. I guess what I meant to say is that there isn't any compiler which defines both WIN32 and CYGWIN (I hope :-)). Any portable code which includes w32api headers before checking if WIN32 is defined isn't going to be very portable :-) -- Jon TURNEY Volunteer Cygwin/X X Server maintainer -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Problem reports: http://cygwin.com/problems.html Documentation: http://x.cygwin.com/docs/ FAQ: http://x.cygwin.com/docs/faq/