public inbox for cygwin-xfree@sourceware.org
help / color / mirror / Atom feed
From: "Earle F. Philhower III" <earle@ziplabel.com>
To: cygwin-xfree@cygwin.com
Subject: Re: Minimising window with "Always on top" attribute leaves contents in underlying window
Date: Mon, 26 Jan 2004 05:10:00 -0000 [thread overview]
Message-ID: <5.1.1.6.2.20040125204439.00aeb290@mail.ziplabel.com> (raw)
In-Reply-To: <40149972.2050200@msu.edu>
Howdy Harold, I thought you were taking it easy for a while!
At 11:37 PM 1/25/2004 -0500, you wrote:
>Any reason for the following in your patch:
>@@ -893,7 +909,7 @@
> if (s_pScreenPriv != NULL)
> s_pScreenPriv->fWindowOrderChanged = TRUE;
> }
>- return 0;
>+ break;
>The thing that strikes me as odd is that you have to return from the
>WM_WINDOWPOSCHANGED message without calling DefWindowProc (which will get
>called if you change that return to a break) in order to prevent Windows
>from breaking that message down into a WM_SIZE and WM_MOVE message and
>sending those in addition. My worry is that you may have essentially
>found a bug in the WM_WINDOWPOSCHANGED handling that was fixed by allowing
>the WM_SIZE and WM_MOVE messages to be generated and handled, when we
>should really fix such a bug instead of accidentally masking its existance.
>I'm not comfortable removing this change from your patch since it will
>then need to be tested again to verify that things work as expected. Since
>you have already been testing it, I figured it would be easier for you to
>do the testing :)
I did extensive testing without that change, actually, because it
took me a while to figure out why the minimize button and sysmenus
worked but the taskbar left-click 2x didn't. ;)
You can remove it, but minimizing the window by 2x-clicking on the
Windows taskbar won't propagate the Z order change w/the same
messages as if you were to use the system menu or the minimize
button. Why? AFAICT the minimize button or menu item send a wm-move,
even if you don't let DefWindowProc() do its thing. I suspect
Explorer sends its own messages when you click on the taskbar,
and they are not the same as the frame WndProc()'s.
FWIW I can't really see any reason not to allow DefWindowProc to have
a shot at the WM_WINDOWPOSCHANGED message, but I'll admit that I've
not gone through all of Kensuke's code...
-Earle F. Philhower, III
earle@ziplabel.com
cdrlabel - ZipLabel - FlpLabel
http://www.cdrlabel.com
next prev parent reply other threads:[~2004-01-26 5:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-26 4:37 Harold L Hunt II
2004-01-26 5:10 ` Earle F. Philhower III [this message]
[not found] <MABBIGKNNKPOMNLEJIGHKEBNCCAA.mikethepsych@blueyonder.co.uk >
2004-01-26 4:08 ` Earle F. Philhower III
-- strict thread matches above, loose matches on Subject: below --
2004-01-25 8:29 Mike Parker
2004-01-25 18:39 ` Jack Tanner
2004-01-25 19:58 ` Jack Tanner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5.1.1.6.2.20040125204439.00aeb290@mail.ziplabel.com \
--to=earle@ziplabel.com \
--cc=cygwin-xfree@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).